Page MenuHomePhabricator

shortcuts: Open new terminals with ctrl+shift+n
ClosedPublic

Authored by ajwillia.ms on Mar 1 2016, 11:15 AM.

Details

Summary

Add a new configurable key binding to open a new terminal window

Test Plan

Either wipe your terminology configuration or bind the new
"Open a new terminal window" option to ctrl+shift+n.
Tapping that key combination will then open a new window.

Diff Detail

Repository
rTRM apps/terminology
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ajwillia.ms updated this revision to Diff 8569.Mar 1 2016, 11:15 AM
ajwillia.ms retitled this revision from to shortcuts: Open new terminals with ctrl+shift+n.
ajwillia.ms updated this object.
ajwillia.ms edited the test plan for this revision. (Show Details)
ajwillia.ms updated this revision to Diff 8579.Mar 2 2016, 8:45 AM

Pass the path to the new terminal and use ecore_exe for portability

billiob edited edge metadata.Mar 3 2016, 4:18 AM

You're missing some code in config.c in config_load() to add this keybinding to existing users. You might want to update CONF_VER to 8.

ajwillia.ms updated this revision to Diff 8588.Mar 3 2016, 1:47 PM
ajwillia.ms edited edge metadata.

update configuration for existing users

This revision was automatically updated to reflect the committed changes.