Page MenuHomePhabricator

Accessibility: Read pre-edit text.
ClosedPublic

Authored by shilpasingh on Jul 7 2016, 7:03 AM.

Details

Summary

Edje_entry: In order to read pre-edit characters as well,
send entry_change_info with preedit,changed
Elm_entry: In order to read pre-edit characters as well,
send text to screen reader on preedit,changed.

Test Plan
  1. Change keyboard language to korean/enable prediction
  2. Check the reading, text should be read even before committing

Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shilpasingh updated this revision to Diff 9540.Jul 7 2016, 7:03 AM
shilpasingh retitled this revision from to [Accessibility]: Read pre-edit text..
shilpasingh updated this object.
shilpasingh edited the test plan for this revision. (Show Details)
shilpasingh retitled this revision from [Accessibility]: Read pre-edit text. to Accessibility: Read pre-edit text..Jul 7 2016, 7:05 AM
shilpasingh updated this object.
shilpasingh edited the test plan for this revision. (Show Details)
shilpasingh added reviewers: thiepha, jihoon, cedric.
shilpasingh added a subscriber: kimcinoo.
cedric requested changes to this revision.Jul 8 2016, 10:54 AM
cedric edited edge metadata.
cedric added inline comments.
src/lib/edje/edje_entry.c
4390

Where does info get freed now ?

This revision now requires changes to proceed.Jul 8 2016, 10:54 AM
raster accepted this revision.Jul 10 2016, 6:33 PM
raster added a reviewer: raster.
raster added a subscriber: raster.
raster added inline comments.
src/lib/edje/edje_entry.c
4390

it's freed by _free_entry_change_info() in the cb for _edje_emit_full() further down. this is abusing something i put in for edje messages (the structured data stuff for script {} handling), but it works. it'll be freed ones the signal emit call is actually done from the message queue.

4393

aaah you fix this leak :)

This revision was automatically updated to reflect the committed changes.
shilpasingh edited edge metadata.Jul 10 2016, 8:57 PM
shilpasingh added subscribers: rajeshps, govi.