Page MenuHomePhabricator
Differential D4157

[Bug] EFL memory leak on Windows(handler continuously increasing)
ClosedPublic
Actions

Authored by i.furs on Jul 12 2016, 4:19 AM.

Details

Reviewers
thiepha
jaehwan
Jaehyun
raster
Hermet
cedric
bowonryu
herb
Commits
rEFL4387f34b5475: [Bug] EFL memory leak on Windows(handler continuously increasing)
Summary

Fix: event need to clese when create event:

event = WSACreateEvent();

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
i.furs updated this revision to Diff 9574.Jul 12 2016, 4:19 AM
i.furs retitled this revision from to EFL memory leak on Windows(handler continuously increasing).
i.furs updated this object.
i.furs edited the test plan for this revision. (Show Details)
i.furs retitled this revision from EFL memory leak on Windows(handler continuously increasing) to [Bux] EFL memory leak on Windows(handler continuously increasing).Jul 12 2016, 4:49 AM
i.furs updated this object.
i.furs added reviewers: bowonryu, herb, Jaehyun, thiepha, Hermet, jaehwan.
i.furs edited subscribers, added: artem.popov, rimmed, NikaWhite; removed: cedric, jpeg.
artem.popov retitled this revision from [Bux] EFL memory leak on Windows(handler continuously increasing) to [Bug] EFL memory leak on Windows(handler continuously increasing).Jul 12 2016, 5:03 AM
artem.popov added reviewers: cedric, raster.
cedric requested changes to this revision.Jul 12 2016, 9:51 AM
cedric edited edge metadata.

To reduce code duplication and future bugs, it would be better to replace this blob of code with a goto end and set res to 0.

This revision now requires changes to proceed.Jul 12 2016, 9:51 AM
raster edited edge metadata.Jul 12 2016, 4:47 PM

yeah.

res = 0;
goto err;

add err at end just before the same loop you added.

raster requested changes to this revision.Jul 12 2016, 4:51 PM
raster edited edge metadata.
i.furs updated this revision to Diff 9579.Jul 13 2016, 1:06 AM
i.furs edited edge metadata.
  • [Bug] EFL memory leak on Windows(handler continuously increasing)
i.furs updated this revision to Diff 9580.Jul 13 2016, 1:15 AM
i.furs edited edge metadata.
  • EFL memory leak on Windows(handler continuously increasing)
raster accepted this revision.Jul 13 2016, 5:01 AM
raster edited edge metadata.

much nicer! :)

Closed by commit rEFL4387f34b5475: [Bug] EFL memory leak on Windows(handler continuously increasing) (authored by zvukzyshyny, committed by raster). · Explain WhyJul 13 2016, 5:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/ecore/ecore_main.c (6 lines)

Diff 9583

View Options

src/lib/ecore/ecore_main.c

Loading...