Page MenuHomePhabricator

[Hosting] Fix work of proxy subrender.
AbandonedPublic

Authored by se.osadchy on Jul 13 2016, 7:52 AM.

Details

Summary

Adding check for NULL size of geometry for use invisible texture.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2303
Build 2368: arc lint + arc unit
se.osadchy updated this revision to Diff 9584.Jul 13 2016, 7:52 AM
se.osadchy retitled this revision from to [Hosting] Fix work of proxy subrender..
se.osadchy updated this object.
se.osadchy edited the test plan for this revision. (Show Details)

This commit need to fix bug https://phab.enlightenment.org/T3949
when we use not NULL texture with some size - all good, but if change visible to 0 - we have NULL size and segfault

cedric edited edge metadata.Jul 13 2016, 11:13 AM

Do you know why the geometry of the texture is 0 ? If it is 0, what are we trying to render ? I guess we could just return, no ?

se.osadchy added a comment.EditedJul 13 2016, 10:59 PM

yes, we have error:
ERR<56237>:evas-gl_common modules/evas/engines/gl_common/evas_gl_texture.c:341 _tex_2d() Fail tex alloc 0x0, intfmt: 1908 intfmtret: 1
Before call _tex_2d() func we have checks for use texture or no but... we not check geometry for ENFN->rectangle_draw()

if add check for NULL texture - we fix segfault, but can't use this texture, and work of genlist_style and other part with visible = 0 was incorrect
so need add check for geometry for correct use invisible textures
for more details please see task #T3949

please review

please review
commit need to Fix bug

please review
commit need to Fix bug

jpeg added a comment.Jul 18 2016, 10:32 PM

I tested with a simple return, works fine here. My driver does not produce any crash anyway, so it's hard to confirm your issue.

Its need for macOS

jpeg added a comment.Jul 19 2016, 12:44 AM

Then please let me know if my patch 38a32e98fbd42bb6e2e9b2d6dabffc236de36c66 fixes it. If it doesn't then I'll apply your patch instead.

yes, its work)

se.osadchy abandoned this revision.Jul 19 2016, 12:53 AM