Page MenuHomePhabricator

Pager: fix zone fetch
AbandonedPublic

Authored by herdsman on Nov 6 2016, 4:21 AM.

Details

Summary

It caused creation of multiple pager instances if used on the second
monitor (zone).
Didn't really know what do about the call in the "move" callback, but it
seems it's not used when I added print logs, so I just removed it.

fix T4831.

Diff Detail

Repository
rE core/enlightenment
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2701
Build 2766: arc lint + arc unit
herdsman updated this revision to Diff 10064.Nov 6 2016, 4:21 AM
herdsman retitled this revision from to Pager: fix zone fetch.
herdsman updated this object.
herdsman edited the test plan for this revision. (Show Details)
herdsman added reviewers: zmike, stephenmhouston.

I don't think this is correct as the move callback is used when dragging the pager gadget on the desktop and needs to switch monitors.

Well even if we keep it, asking for the zone on every MOVE event is kinda overdoing it.
Maybe it should be replaced with a proper drag-and-drop interface and only calculate the zone on "drag finished"?

This only happens when a pager gadget is moved while placing a desktop gadget and a zone check is hardly anything performance wise to write home about. If you did it via just a drop callback, the pager would be inaccurate when dragging between multiple displays. If you did it via a drag move callback, it would be no different than this. This really isn't a problem at all.

zmike added a comment.Nov 7 2016, 7:30 AM

Well even if we keep it, asking for the zone on every MOVE event is kinda overdoing it.
Maybe it should be replaced with a proper drag-and-drop interface and only calculate the zone on "drag finished"?

Gadget dnd is hardly a code hotpath which requires this level of micro optimization.

stephenmhouston requested changes to this revision.Nov 7 2016, 6:24 PM
stephenmhouston edited edge metadata.

This was resolved in git by fixing an issue where shelf and bryce pagers were competing. Revision can be closed now and I would do it if I knew how :)

This revision now requires changes to proceed.Nov 7 2016, 6:24 PM
herdsman abandoned this revision.Nov 7 2016, 11:31 PM

Great, thanks!