Page MenuHomePhabricator

elm_colorselector: Palette Box made center aligned
AbandonedPublic

Authored by Hermet on Nov 18 2016, 1:04 AM.

Details

Reviewers
shilpasingh
Summary

Make the palette center aligned instead of left aligned.

Test Plan

elementary_test->colorselector->please check palette items

Diff Detail

Repository
rEFL core/efl
Branch
color
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2751
Build 2816: arc lint + arc unit
shilpasingh retitled this revision from to elm_colorselector: Palette not center aligned issue fix.
shilpasingh updated this object.
shilpasingh edited the test plan for this revision. (Show Details)
shilpasingh added a reviewer: Hermet.
shilpasingh retitled this revision from elm_colorselector: Palette not center aligned issue fix to elm_colorselector: Palette Box made center aligned.Nov 18 2016, 1:19 AM
shilpasingh updated this object.
shilpasingh edited the test plan for this revision. (Show Details)

For Tizen platform we need palette to be center aligned, but it was left aligned in opensource.
We need to take a call how the UI should be in opensource and based on that take this change.

Hermet requested changes to this revision.Nov 20 2016, 6:40 PM
Hermet edited edge metadata.

this is not a good solution for opensource world.
It sounds this palette needs to provide a function to align items.
How about deciding the alignment acoording to the colorselector alignment values?
ex)
elm_colorselector_palette_align_set(cs, 0.5, 0);

This revision now requires changes to proceed.Nov 20 2016, 6:40 PM

I agree with your point.. but should we have an API? how about we add a data item in edc? because this is more of a UI dependent issue rather than functionality.. Just asking your opinion

Hermet commandeered this revision.Mar 27 2019, 6:33 PM
Hermet edited reviewers, added: shilpasingh; removed: Hermet.
Hermet abandoned this revision.Mar 27 2019, 6:33 PM

This is a too old patch, nobody keeps tracking on this anymore.