Edje: add checking on NULL 3-rd parameter in edje_object_part_external_param_type_get() @fix
ClosedPublic
Actions

Authored by artem.popov on Nov 22 2016, 10:12 AM.

Details

Reviewers

Commits

Summary

add checking on NULL 3-rd parameter (param) before strcmp to avoid segfault

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

artem.popov retitled this revision from to Edje: add checking on NULL 3-rd parameter in edje_object_part_external_param_type_get() @fix.

artem.popov updated this object.

artem.popov edited the test plan for this revision. (Show Details)

please check a comment.

src/lib/edje/edje_external.c
149	Obvisouly, if the param is null, we don't need to perform this for() loop at all.

This revision now requires changes to proceed.Nov 22 2016, 5:35 PM

@fix

Hermet edited edge metadata.

This revision is now accepted and ready to land.Nov 23 2016, 7:13 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/edje/edje_external.c (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10152	843bee8		Nov 22 2016, 10:12 AM	★	★
Diff 2	10159	843bee8		Nov 23 2016, 1:33 AM	★	★
Diff 3	10162	791bdcb	rEFL7372b1d156ec989655204a2b409281a6996fd88c	Nov 23 2016, 7:13 PM	★	★