Page MenuHomePhabricator

Edje: add checking on NULL 3-rd parameter in edje_object_part_external_param_type_get() @fix
ClosedPublic

Authored by artem.popov on Nov 22 2016, 10:12 AM.

Details

Summary

add checking on NULL 3-rd parameter (param) before strcmp to avoid segfault

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
artem.popov retitled this revision from to Edje: add checking on NULL 3-rd parameter in edje_object_part_external_param_type_get() @fix.
artem.popov updated this object.
artem.popov edited the test plan for this revision. (Show Details)
Hermet requested changes to this revision.Nov 22 2016, 5:35 PM
Hermet added a reviewer: Hermet.
Hermet added a subscriber: Hermet.

please check a comment.

src/lib/edje/edje_external.c
149

Obvisouly, if the param is null, we don't need to perform this for() loop at all.

This revision now requires changes to proceed.Nov 22 2016, 5:35 PM
artem.popov edited edge metadata.

Updating D4424: Edje: add checking on NULL 3-rd parameter in edje_object_part_external_param_type_get()

@fix

Hermet accepted this revision.Nov 23 2016, 7:13 PM
Hermet edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 7:13 PM
This revision was automatically updated to reflect the committed changes.