Page MenuHomePhabricator
Differential D4453

Add Battery Support for DragonFly BSD and factorise the code into sysctl subsystem
ClosedPublic
Actions

Authored by netstar on Dec 2 2016, 4:36 PM.

Details

Reviewers
stephenmhouston

Diff Detail

Repository
rE core/enlightenment
Branch
bat
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2837
Build 2902: arc lint + arc unit
netstar updated this revision to Diff 10222.Dec 2 2016, 4:36 PM
netstar retitled this revision from to Add Temperature support for DragonFly BSD and factorise the code into sysctl subsystem.
netstar updated this object.
netstar edited the test plan for this revision. (Show Details)
netstar updated this revision to Diff 10225.Dec 2 2016, 8:21 PM
netstar edited edge metadata.

Add support for FreeBSD too!

netstar added a comment.Dec 2 2016, 8:22 PM

I added FreeBSD support as it seems to work the same as DragonFly and that makes sense.

Am unable to test that bit tho!

netstar updated this revision to Diff 10226.Dec 2 2016, 8:40 PM
netstar edited edge metadata.

Add support for NetBSD too!

netstar updated this revision to Diff 10227.Dec 2 2016, 8:51 PM
netstar edited edge metadata.

Add NetBSD toooo

netstar added a comment.Dec 3 2016, 2:40 AM

need to make a change w/mib stuff will do that later

netstar updated this revision to Diff 10230.Dec 3 2016, 8:20 AM
netstar edited edge metadata.

Use sysctl where possile it is 3 times faster than
sysctltoname.

netstar updated this revision to Diff 10231.Dec 3 2016, 8:24 AM
netstar edited edge metadata.

Indentation!!!!

netstar updated this revision to Diff 10232.Dec 3 2016, 9:49 AM
netstar edited edge metadata.

Update!

netstar updated this revision to Diff 10233.Dec 3 2016, 9:53 AM
netstar edited edge metadata.

Indentation again SRRY!

netstar updated this revision to Diff 10234.Dec 3 2016, 2:16 PM
netstar edited edge metadata.

Forgot to add one sysctl.

netstar updated this revision to Diff 10235.Dec 3 2016, 2:17 PM
netstar edited edge metadata.

Another indentation issue!

netstar updated this revision to Diff 10236.Dec 3 2016, 4:27 PM
netstar edited edge metadata.

What a total pain in the arse these things are!

netstar updated this revision to Diff 10237.Dec 3 2016, 4:29 PM
netstar edited edge metadata.

Another indentation!!!!!

zmike added a comment.Dec 5 2016, 7:38 AM

This is the kind of thing that would be worthwhile to have in eeze to reduce application code...

netstar added a comment.Dec 5 2016, 10:14 AM

I think I'd like to start doing that following the 1.19 release with December and January being what they are - busy months.

It's important to be building EFL and E at least weekly on the different BSDs it saves times and pain in the long run, but for now I'm happy doing that in my spare time.

As mentioned on the mailing list I'm interested in helping expand eeze for these systems. It should be useful for those wanting to develop of these "foreign" platforms without all the mentalism the variations between the systems bring.

netstar added a reviewer: stephenmhouston.Dec 6 2016, 7:54 PM
netstar added a subscriber: stephenmhouston.

Sorry about that, I completely ballsed that up. It's here now @stephenmhouston

netstar retitled this revision from Add Temperature support for DragonFly BSD and factorise the code into sysctl subsystem to Add Battery Support for DragonFly BSD and factorise the code into sysctl subsystem.Dec 6 2016, 7:56 PM
netstar edited edge metadata.
netstar added a comment.Dec 7 2016, 3:22 PM

not sure if you need to change e_mod_bsd.c to e_mod_sysctl.c manually..

the patch generated here needs that manual rename!

Ok night!

stephenmhouston edited edge metadata.Dec 9 2016, 8:05 AM

Part of your patch needs to be removing the deprecated BSD stuff from batget.c

netstar updated this revision to Diff 10277.Dec 9 2016, 8:25 AM
netstar edited edge metadata.

For okra

netstar updated this revision to Diff 10278.Dec 9 2016, 8:27 AM
netstar edited edge metadata.

Typo

stephenmhouston accepted this revision.Dec 9 2016, 9:03 AM
stephenmhouston awarded a token.
stephenmhouston edited edge metadata.

Good work.

This revision is now accepted and ready to land.Dec 9 2016, 9:05 AM
stephenmhouston closed this revision.Dec 9 2016, 9:05 AM

This has now been added in enlightenment git.

Revision Contents
Changeset List

Diff 10235

View Options

configure.ac

Loading...
View Options

src/modules/Makefile_battery.mk

Loading...
View Options

src/modules/battery/e_mod_main.h

Loading...
View Options

src/modules/battery/e_mod_main.c

Loading...
View Options

src/modules/battery/e_mod_openbsd.c

Loading...
View Options

src/modules/battery/e_mod_sysctl.c

Loading...