Page MenuHomePhabricator

elm gesture layer: Add check for NULL and negative input parameters.
AbandonedPublic

Authored by Hermet on Jan 26 2017, 6:15 AM.

Details

Summary

Add set 0 as min length of line if negative input value.
Add return -1 to get finger size from NULL object
@fix

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3164
Build 3229: arc lint + arc unit
se.osadchy created this revision.Jan 26 2017, 6:15 AM
se.osadchy retitled this revision from elm gesture layer: Add check for set negative min length of line. to elm gesture layer: Add check for NULL and negative input parameters..Jan 26 2017, 6:20 AM
se.osadchy edited the summary of this revision. (Show Details)
cedric requested changes to this revision.Feb 7 2017, 1:38 PM

sd can not be NULL. Please explain in which case this patch is necessary.

This revision now requires changes to proceed.Feb 7 2017, 1:38 PM
jpeg requested changes to this revision.Feb 12 2017, 10:16 PM
jpeg added inline comments.
src/lib/elementary/elm_gesture_layer.c
3970

MAX(a,0)

4154

as @cedric said this case is impossible

src/lib/elementary/elm_gesture_layer_common.h
373

It should read "if object is invalid". But then an EAPI wrapper must be written or maybe signal to eolian that the default value is (-1).

Hermet commandeered this revision.Mar 27 2019, 6:47 PM
Hermet edited reviewers, added: se.osadchy; removed: Hermet.
Hermet abandoned this revision.Mar 27 2019, 6:47 PM

This is a too old patch, nobody keeps tracking on this anymore.