Page MenuHomePhabricator

eina mempool: Fix inline optimization for eina_mempool_alignof in header file.
AbandonedPublic

Authored by se.osadchy on Feb 3 2017, 4:34 AM.

Details

Summary

Delete inline optimization due to lcov issue:
Coverage test report of EFL API can't check called or not inline function.
@fix

Diff Detail

Repository
rEFL core/efl
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3364
Build 3429: arc lint + arc unit
se.osadchy created this revision.Feb 3 2017, 4:34 AM
cedric requested changes to this revision.Feb 6 2017, 10:28 AM

Uh ? We do call alignof in a lot of place which may be part of the critical path in some case. It is also a very small function which mostly does math and should inline quite nicely. Now removing this just for a coverage report issue isn't a good enough reason for me. Please add benchmark and make sure that there is no side effect of removing that inline (Also it is unlikely that by itself work as there is an inline directive also in eina_inline_mempool.x).

This revision now requires changes to proceed.Feb 6 2017, 10:28 AM
jpeg requested changes to this revision.Feb 8 2017, 6:50 PM

lcov can't report that an inline function is called? Well that means it's been inlined. So why care at all??

se.osadchy updated this revision to Diff 10889.Mar 14 2017, 9:29 AM
se.osadchy edited edge metadata.
  • Merge branch 'master' of git://git.enlightenment.org/core/efl
  • elm_map: Fix work of elm_map_overlay_icon_set if icon is NULL.
se.osadchy abandoned this revision.Mar 15 2017, 1:33 AM