Page MenuHomePhabricator
Differential D4720

elm_map: Fix work of elm_map_overlay_icon_set if icon is NULL.
ClosedPublic
Actions

Authored by se.osadchy on Mar 16 2017, 1:53 AM.

Details

Reviewers
jpeg
raster
Hermet
cedric
Commits
rEFLa63ce8c2e2be: elm_map: Fix work of elm_map_overlay_icon_set if icon is NULL.
Summary

Delete check on NULL for icon object due to incorrect work. Function must delete
icon in map overlay (according to documentation) if we set NULL, but with this check -
nothing happening and after elm_map_overlay_icon_get we have not NULL returned value.
@fix

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
se.osadchy created this revision.Mar 16 2017, 1:53 AM
se.osadchy added a comment.Mar 16 2017, 1:54 AM

Example for check this issue:

elm_map_icon.c1 KBDownload

cedric accepted this revision.Mar 21 2017, 11:12 AM

It would have been nice if that tests was becoming a part of elementary_test, but the change are quite small and easy to understand. I will let this go in this time.

This revision is now accepted and ready to land.Mar 21 2017, 11:12 AM
Closed by commit rEFLa63ce8c2e2be: elm_map: Fix work of elm_map_overlay_icon_set if icon is NULL. (authored by se.osadchy, committed by cedric). · Explain WhyMar 21 2017, 11:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/elementary/elm_map.c (1 line)

Diff 10920

View Options

src/lib/elementary/elm_map.c

Loading...