Page MenuHomePhabricator

elm_map: Fix work of elm_map_overlay_icon_set if icon is NULL.

Authored by se.osadchy on Mar 16 2017, 1:53 AM.



Delete check on NULL for icon object due to incorrect work. Function must delete
icon in map overlay (according to documentation) if we set NULL, but with this check -
nothing happening and after elm_map_overlay_icon_get we have not NULL returned value.

Diff Detail

rEFL core/efl
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
se.osadchy created this revision.Mar 16 2017, 1:53 AM

Example for check this issue:

cedric accepted this revision.Mar 21 2017, 11:12 AM

It would have been nice if that tests was becoming a part of elementary_test, but the change are quite small and easy to understand. I will let this go in this time.

This revision is now accepted and ready to land.Mar 21 2017, 11:12 AM
This revision was automatically updated to reflect the committed changes.