Page MenuHomePhabricator

ecore_con_legacy: Send server_upgrade event *after* clearing pending saves
ClosedPublic

Authored by bryceharrington on Apr 12 2017, 1:55 PM.

Details

Summary

The _ecore_con_post_event_server_upgrade() call adds an event to free
the server_upgrade object, svr, via _ecore_con_server_free(svr) so we
should assume srv is freed after it returns. Thus, perform the
pending_slice processing prior to calling it. Otherwise it triggers an
illegal access (USE_AFTER_FREE) error in Coverity.

@fix CID1373485

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
This revision is now accepted and ready to land.Apr 12 2017, 2:25 PM
This revision was automatically updated to reflect the committed changes.