Escaping is not happening whenever any escapable characters is coming after
'\t' or '\n'. It will also fix invalid read of 1 byte which happens for string where
last charachter is '\t' or '\n' like "eina\t".
Details
Details
Take a string like "eina\t ". Observe space which is followed by tab is not getting
escaped.
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Could you provide additionnal test for detecting this problem ? This would avoid having it poping back in a few months, years, ...
Comment Actions
Also fixes Invalid read
16673== Invalid read of size 1
16673== at 0x4E723C7: eina_str_escape (in /usr/local/efl-dev/lib/libeina.
so.1.19.99)
16673== by 0x400EC9: main (in /home/prasoon.16/op_source/efl/src/examples
/eina/eina_str_01)
16673== Address 0x5db52e4 is 0 bytes after a block of size 4 alloc'd
16673== at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-
amd64-linux.so)
16673== by 0x400EAF: main (in /home/prasoon.16/op_source/efl/src/examples
/eina/eina_str_01)