Page MenuHomePhabricator

genlist: add reorder mode start/stop for key reordering action
AbandonedPublic

Authored by SanghyeonLee on Jun 21 2017, 1:10 AM.

Details

Summary

genlist need to support reorder feature in key action move up/down as same as gengrid,
so it implemented reorder mode start/stop feature in genlist.

Test Plan

Add genlist reorder test in elementary_test genlist focus group.
you can test this feature by checking 'reoder mode'.

there are some bug when item moving upward.
(*notice) it looks scroll interface show/bring_in calcuation bug, and must be fixed in other patch.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3982
Build 4047: arc lint + arc unit
SanghyeonLee created this revision.Jun 21 2017, 1:10 AM

I think we need this, cause we have already same feature in gengrid.
but we don't need type things, cause genlist only have two direction up/down - and it only can swap the items.

jpeg edited edge metadata.Jul 10 2017, 7:44 PM

Being a new feature this needs to wait until after 1.20. I didn't look at the details.

yeah obviously I should wait. after I updated this patch in phab, I got a mail about e20 alpha feature freeze :p
but that is why I usely upload patch in phab especially about new features not directly push..
can discuss about feature and might have a change to fallback mistakes :)

zmike requested changes to this revision.May 2 2018, 3:53 PM
zmike added a reviewer: woohyun.
zmike added a project: efl.
zmike added a subscriber: zmike.

This patch needs rebasing.

This revision now requires changes to proceed.May 2 2018, 3:53 PM
SanghyeonLee abandoned this revision.Jan 31 2019, 1:03 AM