Page MenuHomePhabricator

popup: fix sizing eval logic when scrollable set TRUE
ClosedPublic

Authored by Blackmole on Jul 10 2017, 3:37 AM.

Details

Summary

When scrollable set TRUE,
scroller must be calculated its size except using item.
If content is removed, scroller doesn't calculate its size, so it has previous size.
So there is a empty space in this case.

@fix

Test Plan
  1. elementary_test -to popup
  2. open "popup-center-title + list content + 2 button (with delete content)"
  3. click "Delete" button
  4. compare between scrollable set true and false

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Blackmole created this revision.Jul 10 2017, 3:37 AM
Blackmole edited the summary of this revision. (Show Details)Jul 10 2017, 3:38 AM
jpeg requested changes to this revision.Jul 10 2017, 7:36 PM

modify elementary_test: content set NULL when button is clicked
Observe that test case.

Why not provide the test case?

This revision now requires changes to proceed.Jul 10 2017, 7:36 PM
Blackmole updated this revision to Diff 11772.Jul 10 2017, 11:19 PM
Blackmole edited edge metadata.

add test case

Blackmole updated this revision to Diff 11773.Jul 10 2017, 11:21 PM

add description to test case

Blackmole edited the test plan for this revision. (Show Details)Jul 10 2017, 11:23 PM
jpeg accepted this revision.Jul 10 2017, 11:42 PM

Awesome, thanks!

This revision is now accepted and ready to land.Jul 10 2017, 11:42 PM
Closed by commit rEFL10d5f11a1450: popup: fix sizing eval logic when scrollable set TRUE (authored by Blackmole, committed by Jean-Philippe Andre <jp.andre@samsung.com>). · Explain WhyJul 10 2017, 11:43 PM
This revision was automatically updated to reflect the committed changes.