Page MenuHomePhabricator

add initial code for efl.ui.popup.list
AbandonedPublic

Authored by Blackmole on Aug 6 2017, 11:15 PM.

Details

Summary

add efl.ui.popup.list class

Test Plan
  1. elementary_test -to efluilistpopup
  2. change position and size, click show popup button

Diff Detail

Repository
rEFL core/efl
Branch
devs/jaehyun/popup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4216
Build 4281: arc lint + arc unit
Blackmole created this revision.Aug 6 2017, 11:15 PM
jpeg edited edge metadata.Aug 7 2017, 11:47 PM

We're moving away from widget items and function pointers in EO... so this API will need to be redesigned with EO in mind.

Jaehyun_Cho requested changes to this revision.Aug 14 2017, 1:05 AM

Please check the comments and let's discuss about content_set() for list popup.

src/lib/elementary/efl_ui_popup_list.c
54

Let's think about which is better.

  1. Store content even though the content is not displayed in list popup.
  2. Do not store content and make error log
src/lib/elementary/efl_ui_popup_list_item.eo
5

I think that it is not necessary to open this method.
Because application developers should use item_append() instead of this.

src/lib/elementary/efl_ui_popup_list_private.h
18

how about func_cb?
I don't know the meaning of org_ here.

19

how about data?
I don't know the meaning of org_ here.

20

what is the meaning of cobj?

21

what is the meaning of wcb?

This revision now requires changes to proceed.Aug 14 2017, 1:05 AM
Blackmole abandoned this revision.Aug 20 2017, 10:20 PM

This concept is abandoned