Page MenuHomePhabricator

layout: call size calculating after text_set(NULL)
ClosedPublic

Authored by Blackmole on Aug 10 2017, 9:23 PM.

Details

Summary

When text set NULL, size is not changed even text is removed.
So, fix that case logic

  1. send text,hidden signal
  2. remove text
  3. call sizing eval to resize layout
Test Plan
  1. run elementary_test -to check
  2. change value last check object
  3. compare before and after

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Blackmole created this revision.Aug 10 2017, 9:23 PM
Jaehyun_Cho requested changes to this revision.Aug 21 2017, 6:04 PM

Please check the comments

src/bin/elementary/test_check.c
29

how about "text is visible when check state is true"?

120

how about "text is visible when check state is true"?

src/lib/elementary/efl_ui_layout.c
1237

Actually this is not related to the size calculation.
If you want to add this code in this patch, you need to modify the patch title and description. (This is another bug)

by the way, I think "edje_object_part_text_set" is enough for this case.

This revision now requires changes to proceed.Aug 21 2017, 6:04 PM
Blackmole updated this revision to Diff 12056.Aug 22 2017, 1:34 AM
Blackmole edited edge metadata.
Blackmole marked 3 inline comments as done.

Following jaehyun's comment

src/lib/elementary/efl_ui_layout.c
1237

So do I.
But I think that when layout get "elm,state,text,hidden" signal, real text part has text is strange.
How about that?

Blackmole updated this revision to Diff 12057.Aug 22 2017, 1:47 AM

Separate patch.

Blackmole updated this revision to Diff 12070.Aug 22 2017, 8:12 PM

fix mistake

This revision was automatically updated to reflect the committed changes.