Page MenuHomePhabricator
Differential D5116

windows: make windows work properly and autosave properly.
ClosedPublic
Actions

Authored by netstar on Aug 22 2017, 2:47 AM.

Details

Reviewers
ajwillia.ms

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4333
Build 4398: arc lint + arc unit
netstar created this revision.Aug 22 2017, 2:47 AM
netstar updated this revision to Diff 12059.Aug 22 2017, 3:07 AM

Refactor the way we save

ajwillia.ms requested changes to this revision.Aug 22 2017, 4:22 AM

Thanks, fixes the issues but introduces a new one, if that can be fixed we're good

src/bin/mainview/edi_mainview.c
280 ↗(On Diff #12059)

Removing this line means that the "open new window" menu option no longer closes the tab and so you get a duplicate open.

This revision now requires changes to proceed.Aug 22 2017, 4:22 AM
netstar added a comment.Aug 22 2017, 4:24 AM
12:23 <netstar> duplicate open is better no?>
12:23 <netstar> say you have the file open in 4 panels and open in window it'll close them all and open in a window
12:23 <netstar> w/o that can open as many as u like anywhere
netstar updated this revision to Diff 12062.Aug 22 2017, 4:28 AM
netstar edited edge metadata.

revert the close

ajwillia.ms accepted this revision.Aug 22 2017, 4:37 AM
This revision is now accepted and ready to land.Aug 22 2017, 4:37 AM
ajwillia.ms closed this revision.Aug 22 2017, 4:39 AM

Revision Contents
Changeset List

Diff 12062

View Options

src/bin/editor/edi_editor.c

Loading...
View Options

src/bin/mainview/edi_mainview_panel.c

Loading...