Page MenuHomePhabricator

efl_ui_image: add new scale type: EFL_UI_IMAGE_SCALE_TYPE_TILE
ClosedPublic

Authored by taxi2se on Aug 22 2017, 4:55 AM.

Details

Summary

Tile is common type which can be used eg: background.
This is added to scale type which can be set/get by
efl_ui_image_scale_type_set/get()
@feature

Test Plan

Run elementary test

Run Image Scale Type
Check radio "Tile".

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
taxi2se created this revision.Aug 22 2017, 4:55 AM
taxi2se updated this revision to Diff 12066.Aug 22 2017, 4:58 AM

Name window name properly in elementary test

jpeg edited edge metadata.Aug 22 2017, 8:21 AM

Without checking the patch yet... I wonder if eventually Ui.Image shouldn't implement the fill property like Evas Image? :) (this comment is not a feature request... yet^^)

jpeg accepted this revision.Sep 19 2017, 2:16 AM

Thanks!!!

src/lib/elementary/efl_ui_image.eo
24

Tile before none is probably better. We can still change the order here (EO only!)

This revision is now accepted and ready to land.Sep 19 2017, 2:16 AM
Closed by commit rEFL40e23ca45933: efl_ui_image: add new scale type: EFL_UI_IMAGE_SCALE_TYPE_TILE (authored by taxi2se, committed by Jean-Philippe Andre <jp.andre@samsung.com>). · Explain WhySep 19 2017, 2:18 AM
This revision was automatically updated to reflect the committed changes.