Page MenuHomePhabricator
Differential D5133

mainview_panel: fix panel focus on click of empty panel.
ClosedPublic
Actions

Authored by netstar on Aug 26 2017, 11:23 AM.

Details

Reviewers
ajwillia.ms
Maniphest Tasks
T5904: Fix panel focus following if the welcome panel is clicked
Summary

@fix T5904

Test Plan
  1. Open a Project
  2. Use the menu option and create 5 empty panels by pressing it 4 times.
  3. click on a panel in any order and then select files.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4371
Build 4436: arc lint + arc unit
netstar created this revision.Aug 26 2017, 11:23 AM
netstar updated this revision to Diff 12099.Aug 26 2017, 11:33 AM

fix again

netstar edited the test plan for this revision. (Show Details)Aug 26 2017, 12:01 PM
netstar updated this revision to Diff 12100.Aug 26 2017, 7:44 PM
netstar edited the test plan for this revision. (Show Details)

return when found

ajwillia.ms requested changes to this revision.Aug 28 2017, 2:58 AM

Works nicely but I'm pretty sure that the loop is not needed...

src/bin/mainview/edi_mainview_panel.c
829

Why loop here? can't we just call _panel_focus((Edi_Mainview_Panel *) data)?

This revision now requires changes to proceed.Aug 28 2017, 2:58 AM
netstar updated this revision to Diff 12104.Aug 28 2017, 5:37 AM

No loop :)

ajwillia.ms accepted this revision.Aug 28 2017, 6:04 AM
This revision is now accepted and ready to land.Aug 28 2017, 6:04 AM
ajwillia.ms closed this revision.Aug 28 2017, 6:05 AM

Revision Contents
Changeset List

Diff 12104

View Options

src/bin/mainview/edi_mainview_panel.c

Loading...