Page MenuHomePhabricator

edje_multisense: fix using undefined macros(ECORE_AUDIO_OUT_RENDER_CLASS/ECORE_AUDIO_OUT_RENDER_EVENT_CONTEXT_FAIL)
ClosedPublic

Authored by i.furs on Oct 11 2017, 8:09 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
i.furs created this revision.Oct 11 2017, 8:09 AM
i.furs added projects: Windows, efl.
i.furs edited the summary of this revision. (Show Details)
i.furs added a subscriber: artem.popov.
i.furs updated this revision to Diff 12534.EditedOct 12 2017, 9:00 AM
  • added checking HAVE_WASAPI(after D5310)

After D5310, shouldn't we just check that ECORE_AUDIO_OUT_RENDER_CLASS is defined ?

cedric requested changes to this revision.Oct 13 2017, 12:18 PM
This revision now requires changes to proceed.Oct 13 2017, 12:18 PM
i.furs updated this revision to Diff 12885.Nov 6 2017, 7:47 AM
This comment was removed by i.furs.
i.furs updated this revision to Diff 12886.Nov 6 2017, 7:48 AM
This comment was removed by i.furs.
i.furs updated this revision to Diff 12887.Nov 6 2017, 7:49 AM
raster added a comment.Nov 6 2017, 5:24 PM

Shoouldn't ecore_audio just have a single portable audio class for all platforms?

i.furs added a comment.Nov 8 2017, 4:20 AM

I think that one implementation of the class ecore_audio is required. And only after initialization class ecore_audio. We can get a list of subclasses (sndfile, wasapi, pulse, ...) that we can use. For default ecore_audio selects the best subclasses for platforms . Example: if is on platforms is wasapi, pulse and 'super_audio')). for window is best wasapi. wasapi will default. but we can to use pulse or 'super_audio'.

This revision was automatically updated to reflect the committed changes.