Page MenuHomePhabricator

efl_ui_popup: replace title_set to efl_text_set with efl_part
ClosedPublic

Authored by Blackmole on Oct 24 2017, 1:20 AM.

Details

Summary

Replace Efl.Ui.Popup.Alert's title set method to using efl_text_set with efl_part

Test Plan

elementary_test -to efluipopupalert

Diff Detail

Repository
rEFL core/efl
Branch
devs/jaehyun/efl_popup
Lint
No Linters Available
Unit
No Unit Test Coverage
Blackmole created this revision.Oct 24 2017, 1:20 AM

Please check the comments

src/lib/elementary/efl_ui_popup_alert.c
49

how about returning EINA_TRUE; here?

52

how about returning this function here?

54

how about removing this return here?

Ignore my comments sorry for confusing.

Jaehyun_Cho accepted this revision.Oct 24 2017, 4:10 AM
Jaehyun_Cho retitled this revision from [efl_ui_popup] replace title_set to efl_text_set with efl_part to efl_ui_popup: replace title_set to efl_text_set with efl_part.
This revision is now accepted and ready to land.Oct 24 2017, 4:10 AM
Jaehyun_Cho closed this revision.Nov 8 2017, 4:11 AM