Page MenuHomePhabricator

evas_vg_load_svg: get rid of static Evas_SVG_Parsing
ClosedPublic

Authored by FurryMyad on Oct 27 2017, 8:31 AM.

Details

Summary

Refactoring.
It is good to store values from that struct in a parsing/loading context

static variable is a big NO NO:

  1. Ugly code design,
  2. Might not work when trying to load more than one SVG file.

@fix

Diff Detail

Repository
rEFL core/efl
Branch
devs/subhransu/vector_work
Lint
No Linters Available
Unit
No Unit Test Coverage
FurryMyad created this revision.Oct 27 2017, 8:31 AM
jpeg accepted this revision.Nov 6 2017, 6:46 PM

Good job!

This revision is now accepted and ready to land.Nov 6 2017, 6:46 PM
Closed by commit rEFLee93543799fc: evas_vg_load_svg: get rid of static Evas_SVG_Parsing (authored by FurryMyad, committed by Jean-Philippe Andre <jp.andre@samsung.com>). · Explain WhyNov 6 2017, 6:57 PM
This revision was automatically updated to reflect the committed changes.
jpeg added a comment.Nov 6 2017, 7:03 PM

@FurryMyad, I merged the rest of your patches. Thanks! I hope you'll keep working on VG :)