Page MenuHomePhabricator

efl_ui_list : applying new interface efl_ui_scroll
AbandonedPublic

Authored by SanghyeonLee on Nov 17 2017, 3:14 AM.

Details

Summary

Applying new interface efl_ui_scroll into efl_ui_list.
This patch is upon the efl_ui_scroll patch in D5222.

Test Plan

test by exapmple in src/examples/elementary

Diff Detail

Repository
rEFL core/efl
Branch
devs/sanghyeonlee/list_scroll
Lint
No Linters Available
Unit
No Unit Test Coverage
SanghyeonLee created this revision.Nov 17 2017, 3:14 AM
SanghyeonLee edited the summary of this revision. (Show Details)Nov 17 2017, 3:15 AM

little comments

src/lib/elementary/efl_ui_list.c
172

below function is for precise_layouter.
precise_layouter only can access efl_ui_list object,
so it must be re-bounded scroll_manager from efl_ui_list method.

src/lib/elementary/efl_ui_list_private.h
99

it can be changed to Eina_Position2D

jpeg added inline comments.Nov 19 2017, 11:12 PM
src/lib/elementary/efl_ui_list.c
71

we don't need (or want) those

jpeg added a comment.Dec 18 2017, 10:09 PM

The patch D5222 is merged, is this still up-to-date?

jpeg added a comment.Dec 19 2017, 10:25 PM

Please abandon this. See D5690.

jpeg requested changes to this revision.Dec 19 2017, 10:25 PM
This revision now requires changes to proceed.Dec 19 2017, 10:25 PM
SanghyeonLee abandoned this revision.Apr 5 2018, 12:41 AM