evas_image_load_png
ClosedPublic
Actions

Authored by pawel1234 on Nov 20 2017, 5:10 AM.

Details

Reviewers

stanluk
lukasz.stanislawski
cedric

Commits

rEFL56abebf236d9: evas: remove warning from image_loaders/png/evas_image_load_png

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

pawel1234 created this revision.Nov 20 2017, 5:10 AM

Herald added subscribers: jpeg, cedric. · View Herald TranscriptNov 20 2017, 5:10 AM

Harbormaster failed remote builds in B5159: Diff 13090!Nov 20 2017, 5:14 AM

Is it the "clobbered" warning?

Yes

Is something wrong with this way of fixing "clubbered warnings"? I think it doesn't spoil anything, but it quiets down unnecessary compiler warnings in this case.

I think it is indeed a correct way to solve it as it force the compiler to fully fetch the value from memory every time instead of caching it in registers. Should have done that earlier.

This revision is now accepted and ready to land.Nov 23 2017, 3:43 PM

Closed by commit rEFL56abebf236d9: evas: remove warning from image_loaders/png/evas_image_load_png (authored by pawel1234, committed by Cedric Bail <cedric@osg.samsung.com>). · Explain WhyNov 23 2017, 3:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/modules/evas/image_loaders/png/evas_image_load_png.c (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13090	372bf10		Nov 20 2017, 5:10 AM	★	★
Diff 2	13170	1f35c23	rEFL56abebf236d93a39547771f4bf6e0dae5abc575b	Nov 23 2017, 3:43 PM	★	★

Diff 13170

View Options

src/modules/evas/image_loaders/png/evas_image_load_png.c