Page MenuHomePhabricator

evas: Removed warning from image_loaders/png/evas_image_load_png
ClosedPublic

Authored by pawel1234 on Nov 20 2017, 5:10 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pawel1234 created this revision.Nov 20 2017, 5:10 AM
jpeg added a comment.Nov 20 2017, 6:09 PM

Is it the "clobbered" warning?

pawel1234 added a comment.EditedNov 23 2017, 2:18 AM

Is something wrong with this way of fixing "clubbered warnings"? I think it doesn't spoil anything, but it quiets down unnecessary compiler warnings in this case.

cedric accepted this revision.Nov 23 2017, 3:43 PM

I think it is indeed a correct way to solve it as it force the compiler to fully fetch the value from memory every time instead of caching it in registers. Should have done that earlier.

This revision is now accepted and ready to land.Nov 23 2017, 3:43 PM
Closed by commit rEFL56abebf236d9: evas: remove warning from image_loaders/png/evas_image_load_png (authored by pawel1234, committed by Cedric Bail <cedric@osg.samsung.com>). · Explain WhyNov 23 2017, 3:59 PM
This revision was automatically updated to reflect the committed changes.