Page MenuHomePhabricator

Efl.Ui.Popup.Anchor: apply group calculate with size problem fix
ClosedPublic

Authored by Blackmole on Dec 14 2017, 12:06 AM.

Details

Summary

Size and align calculation in Efl.Ui.Popup was advanced using group calculate,
so Efl.Ui.Popup.Anchor apply it also.

Test Plan

elementary_test -to efl.ui.popup.anchor

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Blackmole created this revision.Dec 14 2017, 12:06 AM
Blackmole updated this revision to Diff 13518.Dec 14 2017, 6:13 PM

fix indentation

@Blackmole
Please check the comments

src/bin/elementary/test_ui_popup.c
193

how about as follows?
static Eina_Bool size_changed = EINA_FALSE;

src/lib/elementary/efl_ui_popup_anchor.c
226–230

I think that in this case, align calc is only needed.
If so, I think the following code is correct.
Eina_Bool needs_size_calc = ppd->needs_size_calc;
elm_layout_sizing_eval(data);
ppd->needs_size_calc = needs_size_calc;

276

I think that in this case, align calc is only needed.
If so, I think the following code is correct.
Eina_Bool needs_size_calc = ppd->needs_size_calc;
elm_layout_sizing_eval(obj);
ppd->needs_size_calc = needs_size_calc;

Blackmole updated this revision to Diff 13519.Dec 14 2017, 8:35 PM
Blackmole marked 3 inline comments as done.

change variables' name

Jaehyun_Cho accepted this revision.Dec 14 2017, 8:55 PM
This revision is now accepted and ready to land.Dec 14 2017, 8:55 PM
This revision was automatically updated to reflect the committed changes.