Page MenuHomePhabricator

Remove find feature from ui module.
ClosedPublic

Authored by Deepwarrior on Dec 28 2017, 7:47 AM.

Details

Reviewers
i.furs
NikaWhite
Summary

Remove code related to find from ui.c to find.c
Remove dependence find from global_data struct.
Use task registration mechanism for highlight tasks.
Remove useless callbacks, because functions now placed
in same module.

Test Plan

find algorithm haven't changed.
So it shoul work as before.
Need to check, that all ui elements work good too.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5596
Build 6177: arc lint + arc unit
Deepwarrior created this revision.Dec 28 2017, 7:47 AM

Remove useless time field.

NikaWhite accepted this revision.Dec 29 2017, 1:30 AM

I am going to request additional changes in project structure.
Could you please organize the find sub module source code in next way:

-lib/
 |-find/
   |--find.c
   |--find_ui.c
   |--find.h
   |--find_private.h
 |-tasks/
 -ui.c
 -main.c
This revision is now accepted and ready to land.Dec 29 2017, 1:30 AM
NikaWhite closed this revision.Dec 29 2017, 1:30 AM