Page MenuHomePhabricator

Move source code related to plots into plots dir.
AbandonedPublic

Authored by Hermet on Dec 29 2017, 8:48 AM.

Details

Summary

Add plots_ui.c that contain ui part of plots.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5604
Build 6186: arc lint + arc unit
Deepwarrior created this revision.Dec 29 2017, 8:48 AM

Do not merge it to master branch please.
Code require few changes, that happen in next commits.

It can be merged to some additional branch (like devs/deepwarrior/plots_refactoring)

NikaWhite requested changes to this revision.Dec 29 2017, 12:47 PM

I like that.
Please fix my remarks and this commit will be ready to be pushed to the repo.

src/lib/helper.h
548

Each public function should be documented.
Public function name shouldn't begin with '_' symbol

src/lib/plots/plots_ui.c
110

what about that code?

This revision now requires changes to proceed.Dec 29 2017, 12:47 PM
Hermet commandeered this revision.Mar 27 2019, 6:41 PM
Hermet abandoned this revision.
Hermet added a reviewer: Deepwarrior.

This is a too old patch, nobody keeps tracking on this anymore.