Page MenuHomePhabricator

efl_ui_popup: add efl_ui_bg interface to backwall part
AbandonedPublic

Authored by Jaehyun_Cho on Jan 8 2018, 9:11 PM.

Details

Summary

popup's backwall part usage is similar to bg widget,
so add bg interface and use bg widget to backwall part

Test Plan

elementary_test -to efl.ui.popup

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Blackmole created this revision.Jan 8 2018, 9:11 PM
Blackmole updated this revision to Diff 13653.Jan 8 2018, 9:21 PM

rename sub popup's backwall theme

Blackmole updated this revision to Diff 13654.Jan 8 2018, 9:23 PM

remove wrong style name

jpeg added a comment.Jan 8 2018, 9:26 PM

Is hit_rect required?

src/lib/elementary/efl_ui_popup.c
20

data and event are not unused :)

112
efl_gfx_geometry_set(pd->hit_rect, p_geom);
321
p_geom.x = 0;  p_geom.y = 0;
efl_gfx_geometry_set(backwall, p_geom);
efl_gfx_geometry_set(hit_rect, p_geom);
357

why change hit rect visibility here?

@jpeg
Oh, it's my mistake.
At first, bg widget don't support click event, so I add hit rect, but in this case, I think hit rect is not mandotary.
I try to remove it. Thanks.

src/lib/elementary/efl_ui_popup.c
20

sorry, it's my fault. I'll fix it.

321

Oh i got it. I will use geometry set in that case. Thanks.

357

To disable backwall clicked event when backwall's visible state is false.

jpeg added a comment.Jan 8 2018, 10:37 PM

Cool, let me know when you're ready for another review, then :)

Blackmole updated this revision to Diff 13655.Jan 9 2018, 1:14 AM

add geometry_set and remove useless EINA_UNUSED

@jpeg
I tested to remove hit rect, but bg widget didn't apply pointer_mode_set.
I tried to POINTER_MODE_NO_GRAB set to Efl.Ui.Bg_Widget,
but only POINTER_MODE_AUTOGRAB was watched in evas/canvas/evas_events.c.
Do you know some hints to resolve this problem?

cedric added a comment.Mar 6 2018, 5:57 PM

any update on this ?

zmike requested changes to this revision.May 2 2018, 4:30 PM
zmike added a reviewer: woohyun.
zmike added a project: efl.
zmike added a subscriber: zmike.

This patch needs rebasing.

This revision now requires changes to proceed.May 2 2018, 4:30 PM

@Jaehyun_Cho @herb

Could you give a feedback on this ?

Instead of this patch 743e0468e910a4f0928bcbf8f7547203108f0d78 has been submitted to master.

Jaehyun_Cho commandeered this revision.Nov 21 2018, 11:22 PM
Jaehyun_Cho abandoned this revision.
Jaehyun_Cho edited reviewers, added: Blackmole; removed: Jaehyun_Cho.

Instead of this patch, 743e0468e910a4f0928bcbf8f7547203108f0d78 has been submitted to master.