Page MenuHomePhabricator

ecore_drm2: Allow non-pci DRM devices to be selected
ClosedPublic

Authored by n3rdopolis on Jan 10 2018, 4:53 AM.

Details

Summary

This is a tweak to c264ef264f0936632a1603fef45c59a50369631d for D5712 . chosen_dev in the loop was only being set for DRM devices attached to PCI devices. While this is useful for determining if the device is the preferred boot_vga device, There is no apparent requirement (comparing to Weston) for all DRM devices to be attached to a PCI device. (This is considering USB DisplayLink devices. I am not sure how the parent device tree is with these...)

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
n3rdopolis created this revision.Jan 10 2018, 4:53 AM
n3rdopolis edited the summary of this revision. (Show Details)Jan 10 2018, 4:54 AM
ManMower accepted this revision.Jan 10 2018, 9:24 AM

Eh, sure. this matches what weston does and doesn't break my usual use case, so I guess it's ok with me.

Would like to see @devilhorns opinion too because there are other bits here that don't match weston behaviour.

This revision is now accepted and ready to land.Jan 10 2018, 9:24 AM
devilhorns accepted this revision.Jan 10 2018, 9:59 AM

This looks ok to me for landing. There are some differences wrt the Weston stuff, but I don't see this change as causing any harm. Weston has the addition of checking if the 'dev' is kms-capable (which we probably want to add at some point).

This revision was automatically updated to reflect the committed changes.