Page MenuHomePhabricator

ecore_anim: Check for null ptr deref
ClosedPublic

Authored by myoungwoon on Jan 21 2018, 8:13 PM.

Details

Summary

This patch fixes a tentative crash owing to null ptr dereference
ecore_animator_freeze() has a same patch already.

Test Plan

execute test suite

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
myoungwoon requested review of this revision.Jan 21 2018, 8:13 PM
myoungwoon created this revision.
myoungwoon updated this revision to Diff 13721.EditedJan 21 2018, 9:38 PM

ecore evas: Check for null ptr deref

This patch fixes a tentative crash owing to ptr deference.
Unlike ecore_evas_object_cursor_set and ecore_evas_object_cursor_device_set,
ecore_evas_cursor_set uses Ecore_Evas *ee before calling internal function which
internally checks null ptr dereference of Ecore_Evas *ee.

Jaehyun_Cho added inline comments.Jan 21 2018, 10:01 PM
src/lib/ecore_evas/ecore_evas.c
1836 ↗(On Diff #13721)

If you intend to make 2 different patches (i.e. ecore_anim patch and ecore_evas patch), please remove this code from this patch.
And please upload this code to a separate arc diff.

Revert a patch for evore_evas patch

Jaehyun_Cho accepted this revision.Jan 22 2018, 12:07 AM
Jaehyun_Cho retitled this revision from 'ecore animator: Check for null ptr deref to ecore_anim: Check for null ptr deref.
Jaehyun_Cho edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jan 22 2018, 12:07 AM
Closed by commit rEFL6629df5e67c9: ecore_anim: Check for null ptr deref (authored by Myoungwoon Roy, Kim <myoungwoon.kim@samsung.com>, committed by Jaehyun_Cho). · Explain WhyJan 22 2018, 12:09 AM
This revision was automatically updated to reflect the committed changes.