Page MenuHomePhabricator

ecore_evas: Check for null ptr deref
ClosedPublic

Authored by myoungwoon on Jan 21 2018, 11:53 PM.

Details

Summary

This patch fixes a tentative crash owing to ptr dereference.
Unlike ecore_evas_object_cursor_set and ecore_evas_object_cursor_device_set,
ecore_evas_cursor_set uses Ecore_Evas *ee before calling internal function which
internally checks null ptr dereference of Ecore_Evas *ee.

Test Plan

Executes test suite

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
myoungwoon created this revision.Jan 21 2018, 11:53 PM
myoungwoon requested review of this revision.Jan 21 2018, 11:53 PM
Jaehyun_Cho added inline comments.Jan 22 2018, 12:09 AM
src/lib/ecore_evas/ecore_evas.c
1837

Please remove spaces here.

Remove spaces from below line.

Jaehyun_Cho accepted this revision.Jan 22 2018, 1:27 AM
Jaehyun_Cho retitled this revision from ecore evas: Check for null ptr deref to ecore_evas: Check for null ptr deref.
This revision is now accepted and ready to land.Jan 22 2018, 1:28 AM
Closed by commit rEFL1b7089a26b6e: ecore_evas: Check for null ptr deref (authored by Myoungwoon Roy, Kim <myoungwoon.kim@samsung.com>, committed by Jaehyun_Cho). · Explain WhyJan 22 2018, 1:28 AM
This revision was automatically updated to reflect the committed changes.