Page MenuHomePhabricator

ecore_timer: Check for the valid callback func
ClosedPublic

Authored by myoungwoon on Jan 24 2018, 10:35 PM.

Details

Summary

This patch checks whether the callback function is valid or not.
Callback function must be set up for the class.

Test Plan

Execute test suite

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
myoungwoon created this revision.Jan 24 2018, 10:35 PM
myoungwoon requested review of this revision.Jan 24 2018, 10:35 PM

Remove spaces.

Add the logic for ecore_timer_loop_add as well.

jpeg added a comment.Jan 24 2018, 11:04 PM

I don't see any new test case for this? Looks like you should check that ecore_timer_add(NULL) returns NULL, no?

Add a simple test case which checks argument of callback function.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 30 2018, 12:01 AM
Closed by commit rEFL6bb2b8b4027f: ecore_timer: Check for the valid callback func (authored by Myoungwoon Roy, Kim <myoungwoon.kim@samsung.com>, committed by Jean-Philippe Andre <jp.andre@samsung.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.