Page MenuHomePhabricator

ecore_event: Check for the valid type
ClosedPublic

Authored by myoungwoon on Jan 30 2018, 11:06 PM.

Details

Summary

This patch checks for the valid types.
As mentioned API reference documentation, user must know its type before hand.
The type should be chedked like previous efl version and ecore_event_type_flush_internal()

Test Plan

Execute a ecore test suite.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
myoungwoon created this revision.Jan 30 2018, 11:06 PM
myoungwoon requested review of this revision.Jan 30 2018, 11:06 PM

fix wrong submit message

myoungwoon edited the test plan for this revision. (Show Details)Jan 30 2018, 11:12 PM
jpeg added inline comments.Jan 31 2018, 12:17 AM
src/lib/ecore/ecore_events.c
76

return NULL would have been easier :) maybe need to check <= NONE?

myoungwoon updated this revision to Diff 13782.Jan 31 2018, 1:19 AM

update a path according to comments.

myoungwoon updated this revision to Diff 13783.Jan 31 2018, 1:21 AM

Removes spaces

This revision was not accepted when it landed; it landed in state Needs Review.Jan 31 2018, 2:37 AM
Closed by commit rEFL211093b7c523: ecore_event: Check for the valid type (authored by Myoungwoon Roy, Kim <myoungwoon.kim@samsung.com>, committed by Jean-Philippe Andre <jp.andre@samsung.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.