Page MenuHomePhabricator

put a check for shared memory inside __imlib_ShmGetXImage()
ClosedPublic

Authored by avolkov on Feb 1 2018, 3:16 AM.

Details

Reviewers
kwo
Summary

This check actually refers to the internal implementation
and should not be done outside this function.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5715
Build 6351: arc lint + arc unit
avolkov requested review of this revision.Feb 1 2018, 3:16 AM
avolkov created this revision.
avolkov added a reviewer: kwo.Feb 1 2018, 3:19 AM
kwo accepted this revision.Feb 1 2018, 8:01 AM

Looks good to me.
I'm not familiar with Phabricator etc., so what now?
If you send me a regular git patch I can commit that so you can get appropriately attributed.

This revision is now accepted and ready to land.Feb 1 2018, 8:01 AM

With installed and setup arcanist you can type:
git checkout master
arc patch --nobranch D5783
git push
arc close-revision D5783

(https://www.enlightenment.org/contrib/devs/arcanist-guide)

kwo closed this revision.Mon, Sep 30, 10:30 AM