Page MenuHomePhabricator

ecore/evas: add NULL checks to handle argument is NULL.
ClosedPublic

Authored by eagleeye on Feb 5 2018, 11:27 PM.

Details

Summary

ecore_pipe_read_fd/ecore_pipe_write_fd
evas_engine_info_set/get

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eagleeye created this revision.Feb 5 2018, 11:27 PM
eagleeye requested review of this revision.Feb 5 2018, 11:27 PM
eagleeye updated this revision to Diff 13810.Feb 5 2018, 11:52 PM

add NULL checks to evas_engine set/get API

eagleeye retitled this revision from ecore_pipe: add NULL checks to handle Ecore_Pipe is NULL. to ecore/evas: add NULL checks to handle argument is NULL..Feb 5 2018, 11:54 PM
eagleeye edited the summary of this revision. (Show Details)
eagleeye added reviewers: woohyun, Jaehyun, Jaehyun_Cho, jpeg.
jpeg accepted this revision.Feb 6 2018, 12:59 AM

Looks fine but this should have been two patches, ideally :)

This revision is now accepted and ready to land.Feb 6 2018, 12:59 AM
Closed by commit rEFL24b0ae0df5c6: ecore/evas: add NULL checks to handle argument is NULL. (authored by Hosang Kim <hosang12.kim@samsung.com>, committed by Jean-Philippe Andre <jp.andre@samsung.com>). · Explain WhyFeb 6 2018, 3:41 AM
This revision was automatically updated to reflect the committed changes.