Page MenuHomePhabricator

ector: Updated the ector_buffer_pixels_set() api with stride info
ClosedPublic

Authored by smohanty on Feb 7 2018, 12:05 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
smohanty created this revision.Feb 7 2018, 12:05 AM
smohanty requested review of this revision.Feb 7 2018, 12:05 AM
jpeg added a comment.Feb 7 2018, 6:41 PM

looks good. can you do these 2 tiny changes?

src/lib/ector/ector_buffer.eo
80

please document: "in bytes" and "if 0 this will be calculated based on cspace and width"

src/lib/ector/software/ector_software_buffer.c
96

else if (stride < width*pxs) error out

smohanty updated this revision to Diff 13826.Feb 7 2018, 9:25 PM

updated review comment

smohanty marked 2 inline comments as done.Feb 7 2018, 9:26 PM
smohanty added inline comments.
src/lib/ector/software/ector_software_buffer.c
96

done

This revision was not accepted when it landed; it landed in state Needs Review.Feb 7 2018, 10:15 PM
Closed by commit rEFL48433efc43de: ector: Updated the ector_buffer_pixels_set() api with stride info (authored by subhransu mohanty <sub.mohanty@samsung.com>, committed by Jean-Philippe Andre <jp.andre@samsung.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.