Page MenuHomePhabricator

efl_mono: Refactor events
AbandonedPublic

Authored by lauromoura on Apr 23 2018, 3:30 PM.

Details

Reviewers
felipealmeida
Summary

Commits in this review:

1a684a2 efl_mono: Fix support for event arguments.
981aad9 efl_mono: Actually test events by passing things by value and structs
8eeb4f4 efl_mono: Move event generators to its own header.
3cd6882 efl_mono: Instantiate parts in constructor in test
673b656 efl_mono: Reorganize utility functions.
5dc3499 efl_mono: Use PascalCase in events
ddecbc5 eolian_mono: Register is not a kw in C#

Diff Detail

Repository
rEFL core/efl
Branch
cs_event_refactor
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6035
Build 6579: arc lint + arc unit
lauromoura created this revision.Apr 23 2018, 3:30 PM
lauromoura requested review of this revision.Apr 23 2018, 3:30 PM
lauromoura updated this revision to Diff 14269.Apr 23 2018, 3:36 PM

Commits in this review:

1a684a2 efl_mono: Fix support for event arguments.
981aad9 efl_mono: Actually test events by passing things by value and structs
8eeb4f4 efl_mono: Move event generators to its own header.
3cd6882 efl_mono: Instantiate parts in constructor in test
673b656 efl_mono: Reorganize utility functions.
5dc3499 efl_mono: Use PascalCase in events
ddecbc5 eolian_mono: Register is not a kw in C#

lauromoura retitled this revision from eolian_mono: Register is not a kw in C# to efl_mono: Refactor events.Apr 23 2018, 3:36 PM
lauromoura edited the summary of this revision. (Show Details)
cedric added a subscriber: zmike.Apr 23 2018, 3:38 PM

@zmike could you explain your trick with arc/phab to have a serie of dependent commit/phab differential instead of a massive one like here ?

@zmike could you explain your trick with arc/phab to have a serie of dependent commit/phab differential instead of a massive one like here ?

It was something I was afraid could happen =\

(I just arc diff against origin/master )

zmike added a comment.Apr 23 2018, 3:48 PM

It's a bit complicated/hacky right now:

Ideally I'd like to make "more correct" modifications so that we can upstream these changes (the maintainer of git-phab said he would be fine with merging any patches) and not all be running some pastebin script...

lauromoura planned changes to this revision.Apr 23 2018, 7:27 PM

Thanks. Tomorrow morning I'll check it.

Would it be better to just scrap this review and start another one or can git-phab salvage it?

lauromoura abandoned this revision.Apr 24 2018, 7:35 PM

Abandoned as git-phab created other revisions.