efl_mono: Refactor events
AbandonedPublic
Actions

Authored by lauromoura on Apr 23 2018, 3:30 PM.

Details

Reviewers

Summary

Commits in this review:

1a684a2 efl_mono: Fix support for event arguments.
981aad9 efl_mono: Actually test events by passing things by value and structs
8eeb4f4 efl_mono: Move event generators to its own header.
3cd6882 efl_mono: Instantiate parts in constructor in test
673b656 efl_mono: Reorganize utility functions.
5dc3499 efl_mono: Use PascalCase in events
ddecbc5 eolian_mono: Register is not a kw in C#

Diff Detail

Repository

rEFL core/efl

Branch

cs_event_refactor

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6035
Build 6579: arc lint + arc unit

lauromoura created this revision.Apr 23 2018, 3:30 PM

Herald added a subscriber: cedric. · View Herald TranscriptApr 23 2018, 3:30 PM

lauromoura requested review of this revision.Apr 23 2018, 3:30 PM

Harbormaster completed remote builds in B6034: Diff 14268.Apr 23 2018, 3:30 PM

Commits in this review:

lauromoura retitled this revision from eolian_mono: Register is not a kw in C# to efl_mono: Refactor events.Apr 23 2018, 3:36 PM

lauromoura edited the summary of this revision. (Show Details)

@zmike could you explain your trick with arc/phab to have a serie of dependent commit/phab differential instead of a massive one like here ?

In D5981#102054, @cedric wrote:

@zmike could you explain your trick with arc/phab to have a serie of dependent commit/phab differential instead of a massive one like here ?

It was something I was afraid could happen =\

(I just arc diff against origin/master )

It's a bit complicated/hacky right now:

Set up git-phab from https://phabricator.freedesktop.org/diffusion/GITPHAB/repository/master/
Replace actual git-phab script with my modified P216
Do something like git phab attach in a branch where the only commits in the branch that are past master are the ones you want uploaded
- Read git-phab script for cmdline options

Ideally I'd like to make "more correct" modifications so that we can upstream these changes (the maintainer of git-phab said he would be fine with merging any patches) and not all be running some pastebin script...

Thanks. Tomorrow morning I'll check it.

Would it be better to just scrap this review and start another one or can git-phab salvage it?

Abandoned as git-phab created other revisions.

zmike mentioned this in Arcanist and Review | Submission.May 1 2018, 12:58 PM

Revision Contents
Changeset List

		Path
M		src/Makefile_Efl_Mono.am (1 line)
V		src/bin/eolian_mono/eolian/mono/{blacklist.hh ← function_blacklist.hh} (33 lines)
M		src/bin/eolian_mono/eolian/mono/documentation.hh (4 lines)
M		src/bin/eolian_mono/eolian/mono/enum_definition.hh (4 lines)
A	M	src/bin/eolian_mono/eolian/mono/events.hh (305 lines)
V		src/bin/eolian_mono/eolian/mono/{function_blacklist.hh → blacklist.hh}
M		src/bin/eolian_mono/eolian/mono/function_declaration.hh (7 lines)
M		src/bin/eolian_mono/eolian/mono/function_definition.hh (9 lines)
M		src/bin/eolian_mono/eolian/mono/function_pointer.hh (8 lines)
M		src/bin/eolian_mono/eolian/mono/function_registration.hh (4 lines)
M		src/bin/eolian_mono/eolian/mono/helpers.hh (89 lines)
D	M	src/bin/eolian_mono/eolian/mono/keyword.hh (52 lines)
M		src/bin/eolian_mono/eolian/mono/klass.hh (315 lines)
M		src/bin/eolian_mono/eolian/mono/marshall_annotation.hh (6 lines)
M		src/bin/eolian_mono/eolian/mono/marshall_type_impl.hh (7 lines)
M		src/bin/eolian_mono/eolian/mono/name_helpers.hh (195 lines)
D	M	src/bin/eolian_mono/eolian/mono/namespace.hh (27 lines)
M		src/bin/eolian_mono/eolian/mono/parameter.hh (3 lines)
M		src/bin/eolian_mono/eolian/mono/part_definition.hh (3 lines)
M		src/bin/eolian_mono/eolian/mono/struct_definition.hh (15 lines)
M		src/bin/eolian_mono/eolian/mono/struct_fields.hh (7 lines)
M		src/bin/eolian_mono/eolian/mono/type_impl.hh (11 lines)
M		src/bin/eolian_mono/eolian/mono/utils.hh (41 lines)
M		src/bin/eolian_mono/eolian_mono.cc (3 lines)
M		src/examples/elementary/efl_ui_slider_mono.cs (4 lines)
M		src/examples/elementary/efl_ui_unit_converter.cs (6 lines)
M		src/examples/evas/evas_mono_rectangle.cs (2 lines)
M		src/examples/evas/evas_mono_text.cs (4 lines)
M		src/tests/efl_mono/Eo.cs (2 lines)
M		src/tests/efl_mono/Errors.cs (4 lines)
M		src/tests/efl_mono/Events.cs (73 lines)
M		src/tests/efl_mono/libefl_mono_native_test.c (56 lines)
M		src/tests/efl_mono/test_testing.eo (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14268	43c3e68		Apr 23 2018, 3:30 PM	★	★
Diff 2	14269	43c3e68	Commits in this review:	Apr 23 2018, 3:36 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
1a684a22917c	e8cd7f122ec9	981aad9a7eb1	Lauro Moura	efl_mono: Fix support for event arguments. (Show More…)	Apr 18 2018, 7:07 PM
981aad9a7eb1	56a2bbbdf524	8eeb4f49a0ab	Lauro Moura	efl_mono: Actually test events by passing things by value and structs (Show More…)	Apr 11 2018, 4:01 PM
8eeb4f49a0ab	0251c671a74e	3cd6882f7d9b	Lauro Moura	efl_mono: Move event generators to its own header. (Show More…)	Apr 16 2018, 5:44 PM
3cd6882f7d9b	b0d7e3c376c3	673b656ce332	Lauro Moura	efl_mono: Instantiate parts in constructor in test (Show More…)	Apr 16 2018, 3:21 PM
673b656ce332	7a95ff821b7b	5dc34994072a	Lauro Moura	efl_mono: Reorganize utility functions. (Show More…)	Apr 16 2018, 12:26 PM
5dc34994072a	088b730d318f	ddecbc5e2230	Lauro Moura	efl_mono: Use PascalCase in events (Show More…)	Apr 16 2018, 8:36 AM
ddecbc5e2230	555859667333	43c3e68d2f9d	Lauro Moura	eolian_mono: Register is not a kw in C# (Show More…)	Apr 12 2018, 8:24 PM

efl_mono: Refactor eventsAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 14269

src/Makefile_Efl_Mono.am

src/bin/eolian_mono/eolian/mono/blacklist.hh

src/bin/eolian_mono/eolian/mono/documentation.hh

src/bin/eolian_mono/eolian/mono/enum_definition.hh

src/bin/eolian_mono/eolian/mono/events.hh

src/bin/eolian_mono/eolian/mono/function_blacklist.hh

src/bin/eolian_mono/eolian/mono/function_declaration.hh

src/bin/eolian_mono/eolian/mono/function_definition.hh

src/bin/eolian_mono/eolian/mono/function_pointer.hh

src/bin/eolian_mono/eolian/mono/function_registration.hh

src/bin/eolian_mono/eolian/mono/helpers.hh

src/bin/eolian_mono/eolian/mono/keyword.hh

src/bin/eolian_mono/eolian/mono/klass.hh

src/bin/eolian_mono/eolian/mono/marshall_annotation.hh

src/bin/eolian_mono/eolian/mono/marshall_type_impl.hh

src/bin/eolian_mono/eolian/mono/name_helpers.hh

src/bin/eolian_mono/eolian/mono/namespace.hh

src/bin/eolian_mono/eolian/mono/parameter.hh

src/bin/eolian_mono/eolian/mono/part_definition.hh

src/bin/eolian_mono/eolian/mono/struct_definition.hh

src/bin/eolian_mono/eolian/mono/struct_fields.hh

src/bin/eolian_mono/eolian/mono/type_impl.hh

src/bin/eolian_mono/eolian/mono/utils.hh

src/bin/eolian_mono/eolian_mono.cc

src/examples/elementary/efl_ui_slider_mono.cs

src/examples/elementary/efl_ui_unit_converter.cs

src/examples/evas/evas_mono_rectangle.cs

src/examples/evas/evas_mono_text.cs

src/tests/efl_mono/Eo.cs

src/tests/efl_mono/Errors.cs

src/tests/efl_mono/Events.cs

src/tests/efl_mono/libefl_mono_native_test.c

src/tests/efl_mono/test_testing.eo

efl_mono: Refactor events
AbandonedPublic
Actions

Revision Contents
Changeset List