Page MenuHomePhabricator

edje: return proper value from the function.
Needs RevisionPublic

Authored by smohanty on May 3 2018, 9:18 PM.

Details

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6154
Build 6651: arc lint + arc unit
smohanty created this revision.May 3 2018, 9:18 PM
smohanty requested review of this revision.May 3 2018, 9:18 PM
myoungwoon accepted this revision.May 7 2018, 4:31 PM

It looks good to me.

This revision is now accepted and ready to land.May 7 2018, 4:31 PM
Hermet requested changes to this revision.May 13 2018, 9:22 PM

What brought you to change this?

const char *str = ""; => const char *str = NULL;

This obviously changes the API behavior. It may cause crashes.

Need clear reason.

This revision now requires changes to proceed.May 13 2018, 9:22 PM