Page MenuHomePhabricator

Revert "efl_add_ref - fis to use efl_add properly with a parent."
ClosedPublic

Authored by cedric on May 7 2018, 11:26 AM.

Details

Summary

This reverts commit 2fb5cc3ad09f6aaf82b5d1131ac5ed22ed848bd4.

Most of this change where wrong as they didn't affect the destruction
of the object. efl_add_ref allow for manual handling of the lifecycle
of the object and make sure it is still alive during destructor. efl_add
will not allow you to access an object after invalidate also efl.parent.get
will always return NULL once the object is invalidated.
Depends on D6061

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.May 7 2018, 11:26 AM
cedric requested review of this revision.May 7 2018, 11:26 AM
zmike accepted this revision.May 8 2018, 8:21 AM

This patch was posted in a branch many weeks ago with review requested then, so it can be assumed there is nobody with any strong moral objection.

Technically it seems fine as well.

This revision is now accepted and ready to land.May 8 2018, 8:21 AM
This revision was automatically updated to reflect the committed changes.