Differential D6085

eo: only call efl_parent_set(NULL) at the end of invalidate if the object is not invalidating.
ClosedPublic
Actions

Authored by cedric on May 7 2018, 11:28 AM.

Details

Reviewers

zmike

Commits

rEFL546a4c79e070: eo: only call efl_parent_set(NULL) at the end of invalidate if the object is…

Summary

Add also a comment to justify why we do force parent to NULL during invalidate.
Depends on D6084

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cedric created this revision.May 7 2018, 11:28 AM

Herald added a project: efl. · View Herald TranscriptMay 7 2018, 11:28 AM

cedric requested review of this revision.May 7 2018, 11:28 AM

cedric added a child revision: D6086: eo: prevent parenting to an already invalidated parent..

This revision was not accepted when it landed; it landed in state Needs Review.May 24 2018, 4:13 PM

Closed by commit rEFL546a4c79e070: eo: only call efl_parent_set(NULL) at the end of invalidate if the object is… (authored by cedric). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: committers. · View Herald TranscriptMay 24 2018, 4:13 PM

Revision Contents
Changeset List

			Path	Packages
M			src/lib/eo/eo_base_class.c (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14489	0acf2e2		May 7 2018, 11:28 AM	★	★
Diff 2	14733	69c9d5b	rEFL546a4c79e070225754c3cead52fd8127797cffb3	May 24 2018, 4:02 PM	★	★

Status	Author	Revision
Closed	cedric	D6107 eio: properly handle Eio.Model lifecycle inside Elm.Fileselector.
Closed	cedric	D6106 elementary: dayselector use efl_add to create the object, calling efl_del during destructor make no sense.
Closed	cedric	D6105 elementary: no need to check for part during destruction.
Closed	cedric	D6104 elementary: no need for resize an object during destruction.
Closed	cedric	D6103 elementary: colorselector item are created with efl_add, so they are dead when they reach the destructor.
Closed	cedric	D6102 elementary: small correction in the API of Efl.Access.Object to have proper lifecycle.
Closed	cedric	D6101 evas: refactor efl_input_event and remove some of the lifecycle hack.
Closed	cedric	D6100 eo: actually during invalidating we already have an invalidated object.
Closed	cedric	D6099 eo: move EFL internal function ___efl_ref2 also to eo_internal.h
Closed	cedric	D6098 efl: major rewrite of efl_part.
Closed	cedric	D6097 eo: check for allow_parent_unref during efl_unref and silence warning.
Closed	cedric	D6096 eo: make sure efl_noref is always called at the proper time.
Closed	cedric	D6095 eo: add an automatic fallback at the moment when efl_unref instead of efl_del is called.
Closed	cedric	D6094 elementary: object created with efl_add should be destroyed with efl_del.
Closed	cedric	D6093 elementary: object allocated with efl_add should be destroyed with efl_del.
Closed	cedric	D6092 eldbus: fix unref of eldbus to not throw warning all over the place.
Closed	cedric	D6091 eldbus: manage death of children during invalidate.
Closed	cedric	D6090 eldbus: object created with efl_add should be destroyed with efl_del.
Closed	cedric	D6089 ecore: first invalidate the loop and its children, then destroy all the object capability.
Closed	cedric	D6088 eo: optimize efl object reuse by limiting the amount of call to pointer translation.
Closed	cedric	D6087 edje: properly handle lifecycle of edje global object.x
Closed	cedric	D6086 eo: prevent parenting to an already invalidated parent.
Closed	cedric	D6085 eo: only call efl_parent_set(NULL) at the end of invalidate if the object is not invalidating.
Closed	cedric	D6084 ecore_con: correct lifecycle of object used by Efl.Net.Dialer.Ssl.
Closed	cedric	D6083 ecore_con: trigger teardown during invalidate.
Closed	cedric	D6082 ecore_con: it is best to call the super destructor and not touch the object anymore after.
Closed	cedric	D6081 ecore_con: correct a typo wrongly calling super destructor instead of super invalidate.
Closed	cedric	D6080 ecore: correct lifecycle of object used by Ecore_Con legacy.
Closed	cedric	D6079 eo: improve error message by pointing to the class that is creating trouble.
Closed	cedric	D6078 eo: preventing infinite loop by safely iterating over children during destructor.
Closed	cedric	D6077 ecore: properly handle shutdown of Efl.Loop children by using invalidate.
Closed	cedric	D6076 ecore: disable signal during shutdown.
Closed	cedric	D6075 eo: invalidate at the end of efl_invalidate only and prevent infinite recursion with an invalidating phase.
Closed	cedric	D6074 ecore: force close during invalidate of Efl.Io.Buffered_Stream.
Closed	cedric	D6073 elementary: use invalidate instead of overriding del for widget items.
Closed	cedric	D6072 elementary: rely on inheritance instead of faking efl_del behavior.
Closed	cedric	D6071 elementary: make del_pre not return a bool and force rely on Eo ref counting.
Closed	cedric	D6070 elementary: prevent death of list item using Eo ref counting.
Closed	cedric	D6069 elementary: remove now useless walking in item.
Closed	cedric	D6068 elementary: use Eo ref counting to prevent death of genlist items.
Closed	cedric	D6067 elementary: use Eo ref counting to prevent death of gengrid items.
Closed	cedric	D6066 elm_list: prevent list item operations during item deletion
Closed	cedric	D6065 elm_list: fix crash in item deletion
Abandoned	cedric	D6064 evas: handle pointer device deletion after invalidate
Abandoned	cedric	D6063 elm_genlist/gengrid: remove clear in destructor
Closed	cedric	D6062 Revert "efl_add_ref - fis to use efl_add properly with a parent."
Closed	cedric	D6061 eo: to avoid mistake in timing, efl_invalidate should always be triggered before any destructor code.
Accepted	cedric	D6060 Revert "elm config - dont leak config if re-loading it again later on"
Abandoned	cedric	D6059 eio: delay tests until we have started listing some files.

Diff 14733

View Options

src/lib/eo/eo_base_class.c