efl: major rewrite of efl_part.
ClosedPublic
Actions

Authored by cedric on May 7 2018, 11:30 AM.

Details

Reviewers

Commits

rEFL8a513a522e90: efl: major rewrite of efl_part.

Summary

The interface efl_part_get should not be directly called from C, but the efl_part
wrapper should. It rely on efl_noref to properly destroy the object. Binding can
control the lifecycle of the reference the way they want by either calling the
wrapper or efl_part_get directly. It also means that the ugly ___efl_auto_unref_set
doesn't need to be exposed outside of EFL anymore.
Depends on D6097

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cedric created this revision.May 7 2018, 11:30 AM

Herald added a project: efl. · View Herald TranscriptMay 7 2018, 11:30 AM

cedric requested review of this revision.May 7 2018, 11:30 AM

cedric added a child revision: D6099: eo: move EFL internal function ___efl_ref2 also to eo_internal.h.

This revision was not accepted when it landed; it landed in state Needs Review.May 24 2018, 4:15 PM

Closed by commit rEFL8a513a522e90: efl: major rewrite of efl_part. (authored by cedric). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: committers. · View Herald TranscriptMay 24 2018, 4:15 PM

jpeg awarded a token.Nov 26 2018, 1:24 AM

Herald added a subscriber: reviewers. · View Herald TranscriptNov 26 2018, 1:24 AM

segfaultxavi mentioned this in D9799: efl: Make Efl.Part.part_get public.Aug 30 2019, 8:52 AM

Revision Contents
Changeset List

		Path
M		src/lib/edje/edje_part_helper.h (2 lines)
M		src/lib/edje/edje_smart.c (1 line)
M		src/lib/edje/edje_util.c (2 lines)
M		src/lib/edje/efl_canvas_layout.eo (2 lines)
M		src/lib/efl/Efl.h (29 lines)
M		src/lib/efl/Efl.hh (2 lines)
M		src/lib/efl/cxx/efl_part_impl.hh (3 lines)
M		src/lib/efl/interfaces/efl_interfaces_main.c (24 lines)
M		src/lib/efl/interfaces/efl_part.eo (9 lines)
M		src/lib/elementary/efl_ui_button.c (1 line)
M		src/lib/elementary/efl_ui_button_legacy.eo (2 lines)
M		src/lib/elementary/efl_ui_check.c (1 line)
M		src/lib/elementary/efl_ui_check_legacy.eo (2 lines)
M		src/lib/elementary/efl_ui_flip.c (1 line)
M		src/lib/elementary/efl_ui_flip.eo (2 lines)
M		src/lib/elementary/efl_ui_frame.c (1 line)
M		src/lib/elementary/efl_ui_layout_object.c (9 lines)
M		src/lib/elementary/efl_ui_layout_object.eo (2 lines)
M		src/lib/elementary/efl_ui_layout_pack.c (1 line)
M		src/lib/elementary/efl_ui_list_default_item.c (5 lines)
M		src/lib/elementary/efl_ui_list_default_item.eo (2 lines)
M		src/lib/elementary/efl_ui_list_empty_item.c (5 lines)
M		src/lib/elementary/efl_ui_list_empty_item.eo (2 lines)
M		src/lib/elementary/efl_ui_navigation_bar.c (6 lines)
M		src/lib/elementary/efl_ui_navigation_bar.eo (2 lines)
M		src/lib/elementary/efl_ui_navigation_layout.c (1 line)
M		src/lib/elementary/efl_ui_panes.c (1 line)
M		src/lib/elementary/efl_ui_panes.eo (2 lines)
M		src/lib/elementary/efl_ui_popup.c (6 lines)
M		src/lib/elementary/efl_ui_popup.eo (2 lines)
M		src/lib/elementary/efl_ui_popup_alert.c (2 lines)
M		src/lib/elementary/efl_ui_popup_alert.eo (2 lines)
M		src/lib/elementary/efl_ui_popup_alert_scroll.c (1 line)
M		src/lib/elementary/efl_ui_popup_alert_scroll.eo (2 lines)
M		src/lib/elementary/efl_ui_popup_alert_text.c (2 lines)
M		src/lib/elementary/efl_ui_popup_alert_text.eo (2 lines)
M		src/lib/elementary/efl_ui_progressbar.c (5 lines)
M		src/lib/elementary/efl_ui_progressbar.eo (2 lines)
M		src/lib/elementary/efl_ui_progressbar_legacy.eo (2 lines)
M		src/lib/elementary/efl_ui_radio.c (1 line)
M		src/lib/elementary/efl_ui_radio_legacy.eo (2 lines)
M		src/lib/elementary/efl_ui_slider.c (1 line)
M		src/lib/elementary/efl_ui_tab_page.c (8 lines)
M		src/lib/elementary/efl_ui_tab_page.eo (2 lines)
M		src/lib/elementary/efl_ui_textpath.c (1 line)
M		src/lib/elementary/efl_ui_textpath.eo (2 lines)
M		src/lib/elementary/efl_ui_widget.c (3 lines)
M		src/lib/elementary/efl_ui_widget.eo (2 lines)
M		src/lib/elementary/efl_ui_widget_part.eo (2 lines)
M		src/lib/elementary/efl_ui_win.c (1 line)
M		src/lib/elementary/efl_ui_win.eo (2 lines)
M		src/lib/elementary/elc_ctxpopup.c (1 line)
M		src/lib/elementary/elc_fileselector.c (1 line)
M		src/lib/elementary/elc_fileselector_entry.c (1 line)
M		src/lib/elementary/elc_multibuttonentry.c (1 line)
M		src/lib/elementary/elc_naviframe.c (1 line)
M		src/lib/elementary/elc_player.c (5 lines)
M		src/lib/elementary/elc_popup.c (1 line)
M		src/lib/elementary/elm_actionslider.c (1 line)
M		src/lib/elementary/elm_actionslider.eo (2 lines)
M		src/lib/elementary/elm_bubble.c (1 line)
M		src/lib/elementary/elm_bubble.eo (2 lines)
M		src/lib/elementary/elm_ctxpopup.eo (2 lines)
M		src/lib/elementary/elm_dayselector.c (1 line)
M		src/lib/elementary/elm_dayselector.eo (2 lines)
M		src/lib/elementary/elm_entry.c (1 line)
M		src/lib/elementary/elm_entry.eo (2 lines)
M		src/lib/elementary/elm_fileselector.eo (2 lines)
M		src/lib/elementary/elm_fileselector_entry.eo (2 lines)
M		src/lib/elementary/elm_hover.c (1 line)
M		src/lib/elementary/elm_hover.eo (2 lines)
M		src/lib/elementary/elm_inwin.c (1 line)
M		src/lib/elementary/elm_label.c (1 line)
M		src/lib/elementary/elm_label.eo (2 lines)
M		src/lib/elementary/elm_mapbuf.c (1 line)
M		src/lib/elementary/elm_mapbuf.eo (2 lines)
M		src/lib/elementary/elm_multibuttonentry.eo (2 lines)
M		src/lib/elementary/elm_naviframe.eo (2 lines)
M		src/lib/elementary/elm_notify.c (1 line)
M		src/lib/elementary/elm_notify.eo (2 lines)
M		src/lib/elementary/elm_panel.c (1 line)
M		src/lib/elementary/elm_panel.eo (2 lines)
M		src/lib/elementary/elm_part_helper.h (8 lines)
M		src/lib/elementary/elm_player.eo (2 lines)
M		src/lib/elementary/elm_popup.eo (2 lines)
M		src/lib/elementary/elm_scroller.c (1 line)
M		src/lib/elementary/elm_scroller.eo (2 lines)
M		src/lib/elementary/elm_slider.c (5 lines)
M		src/lib/elementary/elm_slider.eo (2 lines)
M		src/lib/eo/Eo.h (15 lines)
A	M	src/lib/eo/eo_internal.h (38 lines)
M		src/lib/eolian_cxx/grammar/part_implementation.hpp (5 lines)
M		src/tests/efl_mono/libefl_mono_native_test.c (2 lines)
M		src/tests/efl_mono/test_testing.eo (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14502	8f94297		May 7 2018, 11:30 AM	★	★
Diff 2	14748	c28eb28	rEFL8a513a522e90253ce7ec85e92c7bc58dfb22a2bc	May 24 2018, 4:02 PM	★	★

Status	Author	Revision
Closed	cedric	D6107 eio: properly handle Eio.Model lifecycle inside Elm.Fileselector.
Closed	cedric	D6106 elementary: dayselector use efl_add to create the object, calling efl_del during destructor make no sense.
Closed	cedric	D6105 elementary: no need to check for part during destruction.
Closed	cedric	D6104 elementary: no need for resize an object during destruction.
Closed	cedric	D6103 elementary: colorselector item are created with efl_add, so they are dead when they reach the destructor.
Closed	cedric	D6102 elementary: small correction in the API of Efl.Access.Object to have proper lifecycle.
Closed	cedric	D6101 evas: refactor efl_input_event and remove some of the lifecycle hack.
Closed	cedric	D6100 eo: actually during invalidating we already have an invalidated object.
Closed	cedric	D6099 eo: move EFL internal function ___efl_ref2 also to eo_internal.h
Closed	cedric	D6098 efl: major rewrite of efl_part.
Closed	cedric	D6097 eo: check for allow_parent_unref during efl_unref and silence warning.
Closed	cedric	D6096 eo: make sure efl_noref is always called at the proper time.
Closed	cedric	D6095 eo: add an automatic fallback at the moment when efl_unref instead of efl_del is called.
Closed	cedric	D6094 elementary: object created with efl_add should be destroyed with efl_del.
Closed	cedric	D6093 elementary: object allocated with efl_add should be destroyed with efl_del.
Closed	cedric	D6092 eldbus: fix unref of eldbus to not throw warning all over the place.
Closed	cedric	D6091 eldbus: manage death of children during invalidate.
Closed	cedric	D6090 eldbus: object created with efl_add should be destroyed with efl_del.
Closed	cedric	D6089 ecore: first invalidate the loop and its children, then destroy all the object capability.
Closed	cedric	D6088 eo: optimize efl object reuse by limiting the amount of call to pointer translation.
Closed	cedric	D6087 edje: properly handle lifecycle of edje global object.x
Closed	cedric	D6086 eo: prevent parenting to an already invalidated parent.
Closed	cedric	D6085 eo: only call efl_parent_set(NULL) at the end of invalidate if the object is not invalidating.
Closed	cedric	D6084 ecore_con: correct lifecycle of object used by Efl.Net.Dialer.Ssl.
Closed	cedric	D6083 ecore_con: trigger teardown during invalidate.
Closed	cedric	D6082 ecore_con: it is best to call the super destructor and not touch the object anymore after.
Closed	cedric	D6081 ecore_con: correct a typo wrongly calling super destructor instead of super invalidate.
Closed	cedric	D6080 ecore: correct lifecycle of object used by Ecore_Con legacy.
Closed	cedric	D6079 eo: improve error message by pointing to the class that is creating trouble.
Closed	cedric	D6078 eo: preventing infinite loop by safely iterating over children during destructor.
Closed	cedric	D6077 ecore: properly handle shutdown of Efl.Loop children by using invalidate.
Closed	cedric	D6076 ecore: disable signal during shutdown.
Closed	cedric	D6075 eo: invalidate at the end of efl_invalidate only and prevent infinite recursion with an invalidating phase.
Closed	cedric	D6074 ecore: force close during invalidate of Efl.Io.Buffered_Stream.
Closed	cedric	D6073 elementary: use invalidate instead of overriding del for widget items.
Closed	cedric	D6072 elementary: rely on inheritance instead of faking efl_del behavior.
Closed	cedric	D6071 elementary: make del_pre not return a bool and force rely on Eo ref counting.
Closed	cedric	D6070 elementary: prevent death of list item using Eo ref counting.
Closed	cedric	D6069 elementary: remove now useless walking in item.
Closed	cedric	D6068 elementary: use Eo ref counting to prevent death of genlist items.
Closed	cedric	D6067 elementary: use Eo ref counting to prevent death of gengrid items.
Closed	cedric	D6066 elm_list: prevent list item operations during item deletion
Closed	cedric	D6065 elm_list: fix crash in item deletion
Abandoned	cedric	D6064 evas: handle pointer device deletion after invalidate
Abandoned	cedric	D6063 elm_genlist/gengrid: remove clear in destructor
Closed	cedric	D6062 Revert "efl_add_ref - fis to use efl_add properly with a parent."
Closed	cedric	D6061 eo: to avoid mistake in timing, efl_invalidate should always be triggered before any destructor code.
Accepted	cedric	D6060 Revert "elm config - dont leak config if re-loading it again later on"
Abandoned	cedric	D6059 eio: delay tests until we have started listing some files.

efl: major rewrite of efl_part.ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 14748

src/lib/edje/edje_part_helper.h

src/lib/edje/edje_smart.c

src/lib/edje/edje_util.c

src/lib/edje/efl_canvas_layout.eo

src/lib/efl/Efl.h

src/lib/efl/Efl.hh

src/lib/efl/cxx/efl_part_impl.hh

src/lib/efl/interfaces/efl_interfaces_main.c

src/lib/efl/interfaces/efl_part.eo

src/lib/elementary/efl_ui_button.c

src/lib/elementary/efl_ui_button_legacy.eo

src/lib/elementary/efl_ui_check.c

src/lib/elementary/efl_ui_check_legacy.eo

src/lib/elementary/efl_ui_flip.c

src/lib/elementary/efl_ui_flip.eo

src/lib/elementary/efl_ui_frame.c

src/lib/elementary/efl_ui_layout_object.c

src/lib/elementary/efl_ui_layout_object.eo

src/lib/elementary/efl_ui_layout_pack.c

src/lib/elementary/efl_ui_list_default_item.c

src/lib/elementary/efl_ui_list_default_item.eo

src/lib/elementary/efl_ui_list_empty_item.c

src/lib/elementary/efl_ui_list_empty_item.eo

src/lib/elementary/efl_ui_navigation_bar.c

src/lib/elementary/efl_ui_navigation_bar.eo

src/lib/elementary/efl_ui_navigation_layout.c

src/lib/elementary/efl_ui_panes.c

src/lib/elementary/efl_ui_panes.eo

src/lib/elementary/efl_ui_popup.c

src/lib/elementary/efl_ui_popup.eo

src/lib/elementary/efl_ui_popup_alert.c

src/lib/elementary/efl_ui_popup_alert.eo

src/lib/elementary/efl_ui_popup_alert_scroll.c

src/lib/elementary/efl_ui_popup_alert_scroll.eo

src/lib/elementary/efl_ui_popup_alert_text.c

src/lib/elementary/efl_ui_popup_alert_text.eo

src/lib/elementary/efl_ui_progressbar.c

src/lib/elementary/efl_ui_progressbar.eo

src/lib/elementary/efl_ui_progressbar_legacy.eo

src/lib/elementary/efl_ui_radio.c

src/lib/elementary/efl_ui_radio_legacy.eo

src/lib/elementary/efl_ui_slider.c

src/lib/elementary/efl_ui_tab_page.c

src/lib/elementary/efl_ui_tab_page.eo

src/lib/elementary/efl_ui_textpath.c

src/lib/elementary/efl_ui_textpath.eo

src/lib/elementary/efl_ui_widget.c

src/lib/elementary/efl_ui_widget.eo

src/lib/elementary/efl_ui_widget_part.eo

src/lib/elementary/efl_ui_win.c

src/lib/elementary/efl_ui_win.eo

src/lib/elementary/elc_ctxpopup.c

src/lib/elementary/elc_fileselector.c

src/lib/elementary/elc_fileselector_entry.c

src/lib/elementary/elc_multibuttonentry.c

src/lib/elementary/elc_naviframe.c

src/lib/elementary/elc_player.c

src/lib/elementary/elc_popup.c

src/lib/elementary/elm_actionslider.c

src/lib/elementary/elm_actionslider.eo

src/lib/elementary/elm_bubble.c

src/lib/elementary/elm_bubble.eo

src/lib/elementary/elm_ctxpopup.eo

src/lib/elementary/elm_dayselector.c

src/lib/elementary/elm_dayselector.eo

src/lib/elementary/elm_entry.c

src/lib/elementary/elm_entry.eo

src/lib/elementary/elm_fileselector.eo

src/lib/elementary/elm_fileselector_entry.eo

src/lib/elementary/elm_hover.c

src/lib/elementary/elm_hover.eo

src/lib/elementary/elm_inwin.c

src/lib/elementary/elm_label.c

src/lib/elementary/elm_label.eo

src/lib/elementary/elm_mapbuf.c

efl: major rewrite of efl_part.
ClosedPublic
Actions

Revision Contents
Changeset List