Page MenuHomePhabricator

elm_ctxpopup: prevent a giant load of errors
ClosedPublic

Authored by bu5hm4n on May 15 2018, 6:29 AM.

Details

Summary

i) There have been 2 sorts of errors, first the items have been deleted

after the list was deleted, thus the list items have already been
destructed. which lead to the error as the popup items destroyed the list
items on destruction as well.

ii) sd->box was attached to the ctxpopup when getting into group_del the

box has already been destroyed by the cleanup logic.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.May 15 2018, 6:29 AM
bu5hm4n requested review of this revision.May 15 2018, 6:29 AM
zmike added a comment.May 15 2018, 6:33 AM

@cedric is this in your lifecycles branch? It seems like something you would be looking at...

cedric accepted this revision.May 24 2018, 2:57 PM

There is indeed a wrong order in the command (The item was being killed after the ctxpopup get cleared). Thanks for the fix !

This revision is now accepted and ready to land.May 24 2018, 2:57 PM
Closed by commit rEFL0090384ef5ac: elm_ctxpopup: prevent a giant load of errors (authored by Marcel Hollerbach <marcel@osg.samsung.com>, committed by cedric). · Explain WhyMay 24 2018, 4:10 PM
This revision was automatically updated to reflect the committed changes.