Page MenuHomePhabricator

[POC]e_comp_object: unswallow the reuse objects before deling the edje obj
AbandonedPublic

Authored by bu5hm4n on May 28 2018, 3:19 AM.

Details

Summary

cw->frame_object is often deleted and newly created, before (due to some
issues) the child objects have not been deleted correctly.

This fixes it by simply unswallowing it before deleting the frame object

fix T6970

Diff Detail

Repository
rE core/enlightenment
Branch
devs/bu5hm4n/bugfixing
Lint
Lint OK
Unit
No Unit Test Coverage
bu5hm4n created this revision.May 28 2018, 3:19 AM
bu5hm4n requested review of this revision.May 28 2018, 3:19 AM

damn it!! let me review the white spaces.

bu5hm4n updated this revision to Diff 14807.May 28 2018, 3:23 AM

fix whitespace errors

Sorry man but it didn't help for me

zmike requested changes to this revision.May 28 2018, 3:42 AM

No.

This is fundamentally wrong and different from legacy behavior. Edje objects do not destroy their swallowed objects upon destruction. A recent change has caused that to begin happening, which is the root of all the issues. I've pinged @cedric about it, and I think he will have some time to fix it.

This revision now requires changes to proceed.May 28 2018, 3:42 AM
bu5hm4n retitled this revision from e_comp_object: unswallow the reuse objects before deling the edje obj to [POC]e_comp_object: unswallow the reuse objects before deling the edje obj.May 28 2018, 3:50 AM
bu5hm4n edited the summary of this revision. (Show Details)

Yeah, anyway, its a POC that shows the issue. And might show other cases.

@JackDanielZ what exactly are you doing ? it works here...

I patched into enlightenment repository, compiled, installed and restarted E. I didn't reboot.

Even after reboot

zmike added a comment.May 28 2018, 6:39 AM

As I said, this patch is wrong and will not fix anything except in one or two corner cases where it will conceal the issue.

bu5hm4n abandoned this revision.May 28 2018, 6:40 AM