Page MenuHomePhabricator

edje: fix lifecycle of swallowed children
ClosedPublic

Authored by bu5hm4n on May 28 2018, 6:41 AM.

Details

Summary

a swallowed child is per doc not deleted when the edje is deleted.
After the call to invalidate is finished all children will loose theire
parents and also be invalidated. However, in the efl_invalidate call,
the event EVAS_CALLBACK_DEL is issued, so this is the right spot. As in
legacy the swallows are in place when the EVAS_CALLBACK_DEL event is
issued.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.May 28 2018, 6:41 AM
zmike requested changes to this revision.May 28 2018, 6:50 AM

This should also handle box and table parts. See e.g., edje_util.c:127

This revision now requires changes to proceed.May 28 2018, 6:50 AM
bu5hm4n updated this revision to Diff 14812.May 28 2018, 7:39 AM

more frees

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2018, 9:54 PM
Closed by commit rEFL665e88f8b462: edje: fix lifecycle of swallowed children (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by cedric). · Explain Why
This revision was automatically updated to reflect the committed changes.