Page MenuHomePhabricator
Differential D6244

eo: make noref also a special count
ClosedPublic
Actions

Authored by bu5hm4n on Jun 5 2018, 12:58 AM.

Details

Reviewers
zmike
Maniphest Tasks
T6983: evas_walk overhead
Commits
rEFLe2d143d19ed7: eo: make noref also a special count
Summary

this brings down the first frame time from 2.0 sec. to something at 0.7
sec.

ref T6983

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Jun 5 2018, 12:58 AM
bu5hm4n requested review of this revision.Jun 5 2018, 12:58 AM
bu5hm4n added a reviewer: zmike.Jun 5 2018, 12:59 AM
bu5hm4n added a subscriber: YOhoho.
zmike accepted this revision.Jun 5 2018, 6:48 AM

This looks good, do you think counters should also be added for invalidate and destruct?

This revision is now accepted and ready to land.Jun 5 2018, 6:48 AM
bu5hm4n added a comment.Jun 5 2018, 6:56 AM

Mhmm I am doing other tests where no special counting is needed but you can directly ask which events are registered in O(1) and insertion is the same

zmike added a comment.Jun 5 2018, 7:13 AM

So then should this be merged or are you doing another change?

bu5hm4n added a comment.Jun 5 2018, 7:22 AM

Thid can be merged :) AS this makes things a lot faster

Closed by commit rEFLe2d143d19ed7: eo: make noref also a special count (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyJun 5 2018, 7:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/eo/eo_base_class.c (8 lines)

Diff 14878

View Options

src/lib/eo/eo_base_class.c

Loading...