Page MenuHomePhabricator

eo: _efl_unref correctly
ClosedPublic

Authored by bu5hm4n on Jun 5 2018, 5:25 AM.

Details

Summary

this function calls _efl_ref in the beginning, so _efl_unref them in the
end. This fixes bugs where wrong evas_object_del is called to often,
which would lead to the internal refcount rising instead of getting to
0.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Jun 5 2018, 5:25 AM
bu5hm4n requested review of this revision.Jun 5 2018, 5:25 AM
zmike accepted this revision.Jun 5 2018, 7:00 AM

This is good. Can you provide an example case in the commit log when you merge so that a test can be written for it?

This revision is now accepted and ready to land.Jun 5 2018, 7:00 AM

I will add a test tomorrow :)

zmike added a comment.Jun 5 2018, 7:54 AM

Sure, but having that info in the log for this commit will make future reading easier.

bu5hm4n updated this revision to Diff 14887.Jun 6 2018, 8:53 AM
bu5hm4n edited the summary of this revision. (Show Details)

Okay, tests are added in D6253.

The overall situation improved, however, we still have about 800 part objects on shutdown that are not deleted, will investigate further.

zmike accepted this revision.Jun 6 2018, 9:40 AM

Great, thanks!

Closed by commit rEFL8d5a39861096: eo: _efl_unref correctly (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by ManMower). · Explain WhyJun 6 2018, 12:24 PM
This revision was automatically updated to reflect the committed changes.