Page MenuHomePhabricator

ecore-evas-x: set draw_block until the window receives a configure event (#2)
ClosedPublic

Authored by zmike on Jun 13 2018, 10:45 AM.

Details

Summary

drawing a non-override window before receiving a configure event results
in an unsized window, breaking spec. it also prevents ecore-evas resize
callbacks from triggering, yielding undefined returns from functions which
attempt to get the geometry of the ecore-evas

this patch improves upon the previous version by handling the case of windows
which are created with the correct initial size, bypassing an initial configure
event

there is still a lot of work to be done in this engine to improve/consolidate
resize-related code and ensure protocol correctness

ref T7008
fix T6907

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jun 13 2018, 10:45 AM
zmike requested review of this revision.Jun 13 2018, 10:45 AM

Please test this a bit more before landing; I verified that elm_test, terminology, and enlightenment all work in sw and gl modes, but there are configuration differences which may cause failures on other machines than mine.

raster accepted this revision.Jun 26 2018, 9:49 PM
raster added a subscriber: raster.

tested for a few days... wayland on 2 devices and x on another... everything is working fine.

This revision is now accepted and ready to land.Jun 26 2018, 9:49 PM
This revision was automatically updated to reflect the committed changes.