Page MenuHomePhabricator

evas: switch to EFL_EVENT_INVALIDATE for event grabber sub-object deletion
ClosedPublic

Authored by zmike on Jun 18 2018, 1:00 PM.

Details

Summary

this requires the parent of the deleted object to be reachable, so use the
invalidate callback as this is the last point during which it's possible to
retrieve a parent object

ref T7030

Depends on D6320

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jun 18 2018, 1:00 PM
bu5hm4n requested changes to this revision.Jun 19 2018, 9:55 AM
bu5hm4n added inline comments.
src/lib/evas/canvas/efl_canvas_event_grabber.c
247

Can the name of the callback be adjusted to _efl_canvas_object_event_grabber_child_invalidate ?

That was also the pattern to all other changes in evas.

This revision now requires changes to proceed.Jun 19 2018, 9:55 AM
zmike updated this revision to Diff 15043.Jun 19 2018, 10:03 AM
zmike edited the summary of this revision. (Show Details)

rename function

bu5hm4n accepted this revision.Jun 19 2018, 10:12 AM

Lovely

This revision is now accepted and ready to land.Jun 19 2018, 10:12 AM
This revision was automatically updated to reflect the committed changes.