evas: switch to EFL_EVENT_INVALIDATE for event grabber sub-object deletion
ClosedPublic
Actions

Authored by zmike on Jun 18 2018, 1:00 PM.

Details

Reviewers

bu5hm4n
Hermet
woohyun
devilhorns

Maniphest Tasks

T7030: efl internals pass null objects to functions which should not be passed null

Commits

rEFLb7cb24c32395: evas: switch to EFL_EVENT_INVALIDATE for event grabber sub-object deletion

Summary

this requires the parent of the deleted object to be reachable, so use the
invalidate callback as this is the last point during which it's possible to
retrieve a parent object

ref T7030

Depends on D6320

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Jun 18 2018, 1:00 PM

Herald added a project: efl. · View Herald TranscriptJun 18 2018, 1:00 PM

Herald added subscribers: committers, cedric. · View Herald Transcript

zmike requested review of this revision.Jun 18 2018, 1:00 PM

zmike added a child revision: D6322: evas: add more error messages when passing invalid objects to evas callbacks.

bu5hm4n requested changes to this revision.Jun 19 2018, 9:55 AM

bu5hm4n added inline comments.

src/lib/evas/canvas/efl_canvas_event_grabber.c
247	Can the name of the callback be adjusted to _efl_canvas_object_event_grabber_child_invalidate ? That was also the pattern to all other changes in evas.

This revision now requires changes to proceed.Jun 19 2018, 9:55 AM

rename function

Lovely

This revision is now accepted and ready to land.Jun 19 2018, 10:12 AM

Closed by commit rEFLb7cb24c32395: evas: switch to EFL_EVENT_INVALIDATE for event grabber sub-object deletion (authored by zmike). · Explain WhyJun 19 2018, 10:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/evas/canvas/efl_canvas_event_grabber.c (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15025	8d33f5a		Jun 18 2018, 12:59 PM	★	★
Diff 2	15043	eff054d	rename function	Jun 19 2018, 10:03 AM	★	★
Diff 3	15068	13b7028	rEFLb7cb24c32395f4f2b1fb0cdb57696d19e7c5a6d6	Jun 19 2018, 10:40 AM	★	★

Status	Author	Revision
Closed	zmike	D6325 elm_list: return from sizing_eval immediately if called during constructor
Closed	zmike	D6324 elm_colorselector: avoid calling functions with null objects
Closed	zmike	D6323 elm_colorselector: avoid passing null to efl functions
Closed	zmike	D6322 evas: add more error messages when passing invalid objects to evas callbacks
Closed	zmike	D6321 evas: switch to EFL_EVENT_INVALIDATE for event grabber sub-object deletion
Closed	zmike	D6320 efl_ui_win: check frame_obj existence before operating on it in pre_render
Closed	zmike	D6319 efl_ui_win: do not attempt to focus a null object on focus-in
Needs Review	zmike	D6318 eo: upgrade missing parent WRN to ERR
Closed	zmike	D6317 elm_scroll: Avoid calls to non-existing part

Diff 15068

View Options

src/lib/evas/canvas/efl_canvas_event_grabber.c