Page MenuHomePhabricator

elm_colorselector: avoid passing null to efl functions
ClosedPublic

Authored by zmike on Jun 18 2018, 1:00 PM.

Details

Summary

this check already existed in the function but was not applied to the
entire function

ref T7030
Depends on D6322

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jun 18 2018, 1:00 PM
bu5hm4n requested changes to this revision.Jun 19 2018, 10:11 AM
bu5hm4n added inline comments.
src/lib/elementary/elm_colorselector.c
1422–1423

Just a nitpick, but if sobj is NULL, isn't that then just another call to efl_*** with NULL as obj ?

This revision now requires changes to proceed.Jun 19 2018, 10:11 AM
zmike requested review of this revision.Jun 19 2018, 10:16 AM
zmike added inline comments.
src/lib/elementary/elm_colorselector.c
1422–1423

efl_isa explicitly expects and handles NULL objects.

bu5hm4n accepted this revision.Jun 19 2018, 10:22 AM

Right.

This revision is now accepted and ready to land.Jun 19 2018, 10:22 AM
This revision was automatically updated to reflect the committed changes.